[native][win]Trying to open a book with video file causes media_decoder.exr to crash

[deyan]

Trying to open a book with video file causes media_decoder.exe to stop responding. The book is attached and the Windows error message

Problem signature:

Problem Event Name: APPCRASH
Application Name: media_decoder.exe
Application Version: 0.0.0.0
Application Timestamp: 4aba541c
Fault Module Name: media_decoder.exe
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 4aba541c
Exception Code: 40000015
Exception Offset: 0045e57a
OS Version: 6.0.6002.2.2.0.256.1
Locale ID: 1026
Additional Information 1: efdf
Additional Information 2: a0db112c0608b3427f34ef0c41cf3a95
Additional Information 3: 305d
Additional Information 4: 93186894d4d2897336808366703a53ac

Read our privacy statement:

​http://go.microsoft.com/fwlink/?linkid=50163&clcid=0x0409

[stefan]

Working branch for the fix is http://sophie2.org/trac/browser/branches/private/stefan/bug2054NewTrunk
In order to fix this bug, the KEY_DATA field of the MediaResourceR4 class (org.sophie2.main.func.media.model.resources module) is defined as follows (in order to enable saving and loading of media content in the specific book that is loading or saving:

/**
 * The {@link BinData} of the media.
 */
public static final SimpleKey<BinData> KEY_DATA = new SimpleKey<BinData>(
		"data", BinData.class, BinData.EMPTY_DATA) {
	@Override
	public void persistR3(ValueRef<BinData> ref, Storage destination,
			PersistenceOptions options, String format) throws IOException {
		final Storage storage = destination.child("media");
		if (options.isSaveMode() && ref.get() == null) {
			return;
		}
		if (options.isLoadMode() && storage.getAttribute("src") == null) {
			ref.set(null);
			return;
		}
		if (options.isLoadMode()) {
			ref.set(new BinData(storage.getParent().getParent().getParent()
				.attribute("_data").attribute("media.dat")
				.getByteContent().getBytes()));
		} else if (options.isSaveMode()) {
			storage.getParent().getParent().getParent().attribute("_data").attribute("media.dat").setByteContent(ref.get());
			storage.attribute("src").setTextContent("./_data/media.dat");
				
		}
	}
};

Related code, regarding the fix: [7074]

[stefan]

Related code, regarding the fix:

• [7072]
• [7074]

[stefan]

Should be noted that the attached file (the book - av2i.sjrb) cannot be used as reference for testing whether the bug is fixed or not, because in the time that the book was created, the saving of the books which contained media was faulty (saving of the book did not really saved any kind of media).

[pap]

• It is nice that we have audio and video in books now but you could've made a better solution.
• Instead of writing/reading the contents of the BinData yourself you should use MasterPersister.persist
• Commited in [7147].
• Have a look at the implementation.

[deyan]

fixed