Ticket #2107 (closed bug)

Opened 10 years ago

Last modified 10 years ago

Cannot create a link on a server book.

Reported by: kyli Owned by: kyli
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: kyli Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description

1) Start the sophie server.
2) Start the sophie author.
3) Open the server test-book.
4) Insert an image, click the links hud.
5) Create new rule, set trigger.
6) The application starts throwing exceptions in the console, several seconds later stops responding.

Change History

comment:1 Changed 10 years ago by kyli

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by kyli

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 10 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s2a_design_started to s3b_implementation_finished
  • Imp._owners set to kyli

The problem is in the LinkTriggerPersister, which does not handle correctly the case when the trigger is null (we have such trigger the we create a new rule and we have not set trigger yet). The fix is: if the trigger is null, nothing should be saved. If the trigger is not saved and we try to load it, we return null.
But when the persister is OK, an assertion in ModelChange does not accept the change on the server, which causes exception in the author, too. The assertion is because of some mysterious problem in the persisters, which somehow have more arguments than they should have. I just commented the assertion, since I do not have a better solution to the problem.
The fix is commited in [7465].

comment:4 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Design_reviewers set to meddle
  • Analysis_reviewers set to kyli
  • Imp._reviewers set to meddle

I talked with Tsachev, he said he had the same problem with that assert, but he solved it without commenting the assert itself, I think you should talk with him and i don't like commenting this assert.

0p (10m)

comment:5 Changed 10 years ago by kyli

  • Owner set to kyli
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:6 Changed 10 years ago by kyli

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:7 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Imp._reviewers changed from meddle to meddle, meddle, todor
  • Imp._score changed from 0 to 4
  • Analysis_score changed from 0 to 4

Merged to the trunk at [7573], we had hard time testing it, because the links and the preview had some problems...

4p (75m)

comment:8 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.