copy-paste-styled-text - Copy and paste external formatted text

[deyan]

when i copy an RTF file and paste into a Sophie text frame

[deyan]

Batch update from file priorities.csv

[deyan]

Batch update from file report_1.csv

[deni]

• Change the DataFlavor of RtfData to "text/rtf"
• Currently when importing RTF data (using RtfTextImportManager two extra linefeeds are imported at the end of the text. This is very inconvenient when the user has copied some text from a text editor and wants to insert it in a text frame that already contains some text.
  • The only solution I could think of was to delete them (after parsing the StyledDocument in RtfTextImportManager):

    HotPos endPos = text.getEnd();
    HotPos beginPos = text.advance(endPos, -2);
    HotInterval interval = new HotInterval(beginPos, endPos);
    if (text.subText(interval).toString().equals("\n\n")) {
    	text = text.replace(interval, ImmHotText.empty());
    }
    

• Fixed in the same branch as Ticket #1730
• Source code: [8183], [8199], [8201], [8203] and [8208]

[deyan]

Batch update from file 0911261.csv

[pap]

• I commited this in trunk in [8223] just because it is harmless to sophie.
• I don't advise you to do several tasks in the same branch unless it is really meaningful. This task could just be patch-solved.
• Now to the design.
  • This just does not work correctly - tested on the dev server.
  • It would be much better to make DndData have a list/array of supported DataFlavors. It seems something natural to DataFlavors as far I looked at ​http://java.sun.com/javase/6/docs/api/index.html?java/awt/datatransfer/DataFlavor.html and how it treats text.
  • Also it doesn't seem as something so hard to implement. And I want to note that the later we make this change the more things to change there will be - my personal experience.
  • I used a tool we have - DataFlavorRecognizer. It didn't show text/rtf on my machine.
  • About the linefeeds - they inconvenient indeed but your solution is bad.
  • First would be better of even using such removing you do it in the RTF to ImmHotText convertion process before you get the hot text. Modifying hot text is somewhat slow.
• Second when I launched this demo ​http://java.sun.com/docs/books/tutorialJWS/uiswing/components/ex6//TextSamplerDemo.jnlp and pasted some text from OpenOffice inside it I got no problems and I uses StyledDocument too.
  • Even if we accept this dirty "solution" it is quite bad to just put it in the code without any note.

[deni]

• Make DndData keep a list of supported flavors (instead of a single one):
  • Change the private final DataFlavor flavor field to private final ImmList<DataFlavor> flavors .
  • Keep the constructor by DataFlavor argument for convenience, but add another one by DataFlavor[] .
  • Make DndData.getDataFromAwt() iterate through all supported flavors and call Transferable.getTransferData(DataFlavor) for the first possible.
  • Make DndData.getDataFromAwtUnchecked(Class<T>) call getDataFromAwt(), wrap the checked exceptions into runtime exceptions and cast the result.

• Change the return type of DndProvider.getSupportedFlavor() from DataFlavor to DataFlavor[].
  • Most DndDatas have a static DataFlavor field containing the supported flavor. Make it an array of DataFlavors.
  • In RTFData add to the array DataFlavors with MIME type "text/richtext", representation class InputStream and different charsets.

• Make SophieTransferable respect the above changes.

• Not exactly part of this ticket, but fix finding the first position of a styled interval in ImmHotText.getNormalizedStyleValues(). In case the start position is not in the text, replace it with the begin of the text. However, make sure to convert it to the HotPosKind of the original position.
  • Keeping a position outside the current text cause the following problem when copying text. If we have the texts "aaaaaaaaaa" and "bbbbb" with all b-s bold and copy the last 3 b-s after the second a, the first 2 a-s will become bold, too.

[meddle]

Merged to the trunk at [8525], very nice

4.5p

[meddle]

Closing all the tickets before M Y1