Ticket #2246 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

templates-not-saved -- Book templates do not appear after restart of Sophie

Reported by: deyan Owned by: meddle
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 68 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: meddle
Imp._owners: meddle Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: pap Imp._reviewers: pap, deyan
Test_reviewers: Analysis_score: 4
Design_score: 4.5 Imp._score: 4
Test_score: 0

Description

Create a book, save it as a template, restart Sophie, the template is gone.

Attachments

2246.patch (1.5 KB) - added by meddle 10 years ago.
Implementation code

Change History

comment:1 Changed 10 years ago by deyan

  • Importance set to 68

comment:2 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:3 Changed 10 years ago by meddle

  • Status changed from s1b_analysis_finished to s2a_design_started
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 4

Works for me... 4p

comment:4 Changed 10 years ago by meddle

  • Design_owners set to meddle

comment:5 Changed 10 years ago by meddle

  • Status changed from s2a_design_started to s2b_design_finished

In the FileMenuLogic#ON_SAVE_BOOK_AS_TEMPLATE somebody forgot that the String objects are immutable while constructing the file name to save and the book_templates directory is not added before the file name...So the file is saved directly in "distrib" but when loading the book templates the app searches in the "distrib/book_templates" folder for templates...

Funny :)

comment:6 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok

comment:7 Changed 10 years ago by meddle

  • Owner set to meddle
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to meddle

Changed 10 years ago by meddle

Implementation code

comment:8 Changed 10 years ago by meddle

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 10 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4.5
  • Design_reviewers set to pap
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to pap, deyan
  • Commited in [8578]
  • Works but first there is some quite unpleasant problem when you close the book that was saved as template and then try to make a new book from that template. This throws and exception related to MasterAccesses. This will be reported as some tickets.
  • There is a bit unpleasant behavior with windows where on saving a book created from a template the dialog offers to save it in the book_templates direcotry.

comment:10 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.