Ticket #2249 (closed tweak: obsolete)

Opened 10 years ago

Last modified 8 years ago

changes-lost-on-save-as -- When you save book as, you can't undo/redo anymore

Reported by: deyan Owned by: mira
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 39 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: mira Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 4
Test_score: 0

Description

When you save book as, you cannot undo/redo changes made on that book anymore.

Attachments

undoRedoAfterSave.patch (5.1 KB) - added by mira 9 years ago.
patch

Change History

comment:1 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_owners set to deyan

comment:3 Changed 9 years ago by deyan

  • Importance set to 39

comment:4 Changed 9 years ago by mira

  • Design_owners set to mira
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Imp._owners set to mira
  • Analysis_reviewers set to mira
  • Analysis_score changed from 0 to 3

comment:5 Changed 9 years ago by mira

  • Owner changed from deyan to mira
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 9 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

This happens because the new file access has different viewId than the old one. The switching of views should be transperant to the user and the view id should be the same.
Also the clone revision method is no good for this case isnce it always returns initial revision and the changes are lost. When saving a book to the server or from the server we would need new revision. However, when working with local revisions (mem->file access) the head should be the same, i.e. to keep all of the history.
SaveAsTemplate functionality could also benefit from this since now when saving a server book an exception is shown.

In this change-set I will also make the closing of accesses to be the last thing in the try-catch block of saving a book so that if there are any problems the access is not opened.

comment:7 Changed 9 years ago by mira

  • Status changed from s2b_design_finished to s2c_design_ok

comment:8 Changed 9 years ago by mira

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 9 years ago by mira

patch

comment:9 Changed 9 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

There is patch file attached.

comment:10 Changed 9 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, todor

Merged to the trunk at [8514].

The javadoc in the getTopRevision method is unfinished, when you read this come to me to finish it :P

4p

comment:11 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.