Ticket #2268 (closed tweak: obsolete)

Opened 9 years ago

Last modified 8 years ago

tab-button-size

Reported by: kyli Owned by: meddle
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: kyli, deyan Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: kyli Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, deyan
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description

  1. Make vertical tab buttons 30px wide, and horizontal ones 25px tall.
  2. Make the margin between the tab buttons and the frame border as small as possible.

Attachments

2268.patch (12.1 KB) - added by kyli 9 years ago.

Change History

comment:1 Changed 9 years ago by kyli

  • Owner set to kyli
  • Status changed from new to s1a_analysis_started
  • Milestone set to X3

comment:2 Changed 9 years ago by kyli

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 9 years ago by kyli

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:4 Changed 9 years ago by kyli

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 9 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners set to kyli

Design

  • In SkinDefIds, replace "main.layout.md-main-window/tab-button-thickness" with "main.layout.md-main-window/vert-tab-button-thickness" and "main.layout.md-main-window/hor-tab-button-thickness", with values 30 and 25.
  • In the setup() method of MDMainWindow.toolWindowManager(), set the top and bottom thickness to the horizontal skin value, and the left and right set to the vertical one.
  • Modify peko's "ugly bugfix" in SophieTabButtonUI, so that it works with the new values.
  • Replace constant MYDOGGY_TAB_BUTTON_THICKNESS with MYDOGGY_V_TAB_BUTTON_THICKNESS and MYDOGGY_H_TAB_BUTTON_THICKNESS in MDManageable.
  • In SophieToolWindowBar, modigy the layouts so that they have only one row/column, which fills the available area. Then modify all the layout constraints in the same class.

Implementation


The changes are just several, so I will only attach a patch to this ticket.

Changed 9 years ago by kyli

comment:6 Changed 9 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 4
  • Imp._reviewers set to meddle, deyan
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4

Merged to the trunk at [8523]

comment:7 Changed 9 years ago by meddle

  • Owner changed from kyli to meddle
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 9 years ago by meddle

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 9 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok

comment:10 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.