Ticket #2278 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

delete-resources-exceptions -- Deleting some resources that are in use is permitted

Reported by: deyan Owned by: mira
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: mira Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, deyan, todor
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 3
Test_score: 0

Description (last modified by diana) (diff)

Some of the resources in use can be deleted (they should not)

  • Audio that is used for background
  • Image that is used for background

Attachments

2278.patch (8.9 KB) - added by diana 10 years ago.
deleteResources.patch (50.0 KB) - added by mira 10 years ago.
change set
deleteResources.2.patch (67.8 KB) - added by mira 10 years ago.
The final version of the patch. There is no need to apply the other ones.

Change History

comment:1 Changed 10 years ago by diana

  • Category set to unknown
  • Design_owners set to diana
  • Imp._owners set to diana
  • Description modified (diff)
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Status changed from new to s1b_analysis_finished
  • Imp._score set to 0
  • In ResourceDeleteLogic in isMainResourceUsed function check if the resource is used as a background image or as a background audio.

Changed 10 years ago by diana

comment:2 Changed 10 years ago by diana

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s3b_implementation_finished

comment:4 Changed 10 years ago by mira

  • Status changed from s3b_implementation_finished to s1c_analysis_ok

comment:5 Changed 10 years ago by mira

  • Design_owners changed from diana to mira
  • Status changed from s1c_analysis_ok to s2a_design_started
  • Imp._owners changed from diana to mira
  • Analysis_reviewers set to mira
  • Analysis_score changed from 0 to 3
  • Owner set to mira

comment:6 Changed 10 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

I am going to extend the logic of the method isMainResourceUsed and change its name to just isResourceUsed. It is going to get two arguments - ResourceH. One is representing the resource that we want to delete and the other the eventual parent resource. It will simply get all known keys and if they keep ResourceRefferer value check if this value is the resource we are looking for. It is going to be called recursively for all children of the parent resource if there are any.

Since there is an interface ResourceRefferer<T> I am going to remove the two other interfaces with very similar purpose - ResourceRef -Wrapper and -Holder.

comment:7 Changed 10 years ago by mira

  • Status changed from s2b_design_finished to s2c_design_ok

I am going to extend the logic of the method isMainResourceUsed and change its name to just isResourceUsed. It is going to get two arguments - ResourceH. One is representing the resource that we want to delete and the other the eventual parent resource. It will simply get all known keys and if they keep ResourceRefferer value check if this value is the resource we are looking for. It is going to be called recursively for all children of the parent resource if there are any.

Since there is an interface ResourceRefferer<T> I am going to remove the two other interfaces with very similar purpose - ResourceRef -Wrapper and -Holder.

comment:8 Changed 10 years ago by mira

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 10 years ago by mira

change set

comment:9 Changed 10 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Implementation is made according to the design. - deleteResources.patch

Changed 10 years ago by mira

The final version of the patch. There is no need to apply the other ones.

comment:10 Changed 10 years ago by mira

There is final patch attached to this ticket. It includes a fix to the deletion of book elements.

comment:11 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle, deyan, todor

Merged to the trunk at [8629].

  • The are some invisible frames (null frames, we don't how they are created), that are undeleteable if you don't do a special row of actions...

comment:12 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.