drag-out – Should be able to drag resources out of Sophie

[deyan]

Should be able to select multiple resources from the resources palette and drag them out of the Sophie window. This should export all of the resources as different files depending on their type.

[deyan]

Batch update from file 2401.csv

[deni]

• Will be implemented only for a single resource, partly because selecting multiple resources in a palette is not currently supported.
• All resources will be exported in Sophie2 format.

[deni]

• FileListData changes:
  • Make the List<File> getFiles() method abstract.
  • When the FileListDndProvider creates a new FileListData, the abstract method should be implemented. Move its current implementation there.

• CommonResourceDataProvider and ResourceTransferable changes:
  • CommonResourceDataProvider should be an extension for datas that all resources provide. This can be achieved in two ways:
    • Make all other ResourceDataProviders extend it, or
    • In ResourceTransferable.registerData(List<DndData>) register the datas from all appropriate providers (i.e. remove the 'return' statement).
    • I prefer the second option, because it is easier to implement.
  • CommonResourceDataProvider should provide FileListData, in addition to ResourceRef- and ResourceRevisionData.
    • It will use SophieFormatExportManager to export the resources into files.
    • In order to initialize the format manager, it will need the current resource locator. It will get it from the transferable.
  • ResourceTransferable will have a new ResourceLocator private field, a getter for it and an argument in the constructor.

• Exporting ResourceTransferables when dragging out of the Resources palette is already written - AllResourcesPaletteLogic.ON_DND_EXPORT

• Problems with the current implementation:
  • Copy/paste of frames - instead of pasting the frame, an error message that the file cannot be pasted appears. Maybe we should make sure that the operation for pasting frames is with higher priority that the one that handles pasting files.
  • There is something wrong with the dependencies between modules. I need main.dnd to depend on main.func.resources in order to use an ExportManager in CommonResourceDataProvider, but it caused a cyclic dependency.
    • I moved CommonResourceDataProvider in main.func.resources and it worked.
  • I think that as soon as you copy or start dragging a resource, the file is created somewhere (when running fake in sophie2-platform/modules/org.sophie2.launcher). Probably it should be removed...

[meddle]

• I think the design passes, please make sure that there are no exceptions...
• For the implementation, attach new patch, this one can not be applied, I lost 15 minutes trying to work it out...

3.5p

[deni]

• CommonResourceDataProvider was moved to main.func.resources.
• All files created when copying or dragging a resource are in the temp folder. They are not created by File.createTemFile(...), because it changes their names. However they should be deleted when the JVM in which Sophie is running stops.
• I changed the sortkeys of the operations in ResourceImportLogic so that dropping a resource is before dropping a file.
• Source code: [8664]

[deni]

• Split FileListData in two classes.
  • The data flavors it supports have different representation classes (List<File> for javaFileListFlavor and String for "text/uri-list"). When exporting it to awt transferable, a ClassCastException was thrown.
  • abstract class BaseFileListData extends DndData - Base class for implementations of DndData responsible for transferring files.
    • All logics that previously worked with FileListData will now work with the base class.
  • abstract class JavaFileListData extends BaseFileListData - uses DataFlavor.javaFileListFlavor}
  • abstract class URIListData extends BaseFileListData - uses "text/uri-list;class=java.lang.String" data flavor.

• Make sure that there are no conflicts between ON_DROP_FILE and ON_DROP_RESOURCE_OVER_PWA operations:
  • ON_DROP_FILE should be first, because when dragging files inside Sophie in Linux, we have both plain text and "uri-list" datas. If the ON_DROP_RESOURCE_OVER_PWA is first, it will insert a new text frame with the filenames as content. However, this is not the expected behavour.
  • In ON_DROP_FILE we should check whether the transferable contains ResourceRef- or ResourceRevisionData. If so, it should not handle the event. This is necessary, because we don't want to go through files when tranferring resources internally, although ResourceTransferables have file data and this is possible.

• Source code: [8664] and [8666]

[deni]

• Please review this ticket together with #2302

[kyli]

• The results from the testing were that this code does not work on some linux platforms (I was testing it on 64 bit Ubuntu 9.04 and received "Operation not supported" error. Same was in 32 bit Fedora. It runs OK on Windows, Mac and 64 bit Debian). Please, inspect the problems with the platforms I mentioned.
• Implementations based on this one should be done in the branches/private/kyli/dnd branch. It contains all the code so far, as well it is merged with the current trunk. The old branch causes too much conflicts.

2p.

[meddle]

Closing all the tickets before M Y1