Ticket #2302 (closed tweak: obsolete)

Opened 9 years ago

Last modified 8 years ago

copy-paste-files-from – Should be able to paste files from Sophie

Reported by: deyan Owned by: deni
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 50 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: deni Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: kyli
Test_reviewers: Analysis_score: 4
Design_score: 3.5 Imp._score: 2
Test_score: 0

Description (last modified by deyan) (diff)

Should be able to paste files into OS. The behavior should be like it is for the drag and drop to the OS. See #2300

Change History

comment:1 Changed 9 years ago by deyan

  • Description modified (diff)

Batch update from file 2401.csv

comment:2 Changed 9 years ago by dido

  • Category set to unknown
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Keywords 50 added
  • Imp._score set to 0

comment:3 Changed 9 years ago by dido

  • Importance set to 50
  • Keywords 50 removed

comment:4 Changed 9 years ago by deni

  • Owner set to deni
  • Status changed from new to s1a_analysis_started

comment:5 Changed 9 years ago by deni

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:6 Changed 9 years ago by deni

  • Design_owners set to deni
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Imp._owners set to deni
  • Analysis_reviewers set to deni

comment:7 Changed 9 years ago by deni

  • Analysis_score changed from 0 to 4

comment:8 Changed 9 years ago by deni

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 9 years ago by deni

  • Status changed from s2a_design_started to s2b_design_finished
  • Copy-paste frames behaves differently from export-import - copy encapsulated the frame so that it contains its main resource and export doesn't. Therefore pasting a file in the file system (after copying something from the work area) will be slightly different from dragging a resource out of the resources palette:
    • The file pasted from the file system will contain the main resource of the frame and when it is imported, it will import both the frame and its main resource.
  • In CommonResourceDataProvider.exportFiles(ResourceTransferable) explicitly check whether the resource is a CompositeDndElement and if so, export to files all its children. In this way if we have copied several frames, when pasting them in the file system, they will be exported to separate files.
  • In ResourceImportUtil.importResource(ResourceImportProvider, ResourceH, File) we should take into account that the file may contain encapsulated resources (frames, groups, etc). After importing the resource, we should decapsulate it.

comment:10 Changed 9 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle

It's cool...

  • But what does this check if (valueRefModel != null) in the CopyUtil do?
  • Changing significant actions to insignificant... You must be sure all the import use cases work...

3.5p

comment:11 Changed 9 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:12 Changed 9 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • In CopyUtil.decapsulate(...) the reference passed when decapsulating the children resources was wrong - it should be the child reference appended to the current one, not just the child reference.


  • Frames and groups that are imported could not be deleted, because there were no views for them. I added a simple AutoAction for such cases in ResourceDeleteLogic.deleteElement(DeleteResourceButton, ElementH, BookDocView).
  • In GroupHalosLogic.ON_GROUP_DELETED the arguments passed to ResourceRefR4.getRelativeRef(ResourceRefR4, ResourceRefR4) were swapped and this caused an exception when trying to delete a group.
  • In ResourceDeleteLogic.ON_DELETE_RESOURCE we should use AppViewUtil.getCurrentBookDocView(palette) instead of palette.findNearestElement(null, BookDocView.class) to get the current book doc view.
  • Please note, that this task is in the same branch as #2300 and depends on it. Maybe they should be reviewed together.

comment:13 Changed 9 years ago by kyli

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._reviewers set to kyli
  • Imp._score changed from 0 to 2
  • Changelog set to [wiki:Changelog]
  • The results from the testing were that this code only works for Windows platforms. Please, revise your code and make sure it also works for Mac OS and Linux.
  • Implementations based on this one should be done in the branches/private/kyli/dnd branch. It contains all the code so far, as well it is merged with the current trunk. The old branch causes too much conflicts.

2p.

comment:14 Changed 8 years ago by meddle

  • Status changed from s2c_design_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.