Ticket #2303 (closed tweak: obsolete)

Opened 9 years ago

Last modified 8 years ago

background-drop-zome – Create 15px invisible drop zone for background

Reported by: deyan Owned by: deni
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc: deni
Category: unknown Effort:
Importance: 60 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: Changelog: Changelog
Design_reviewers: Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 0
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

Create a 15 px invisible zone inside pages and frames (next to border). When image is dropped there, it should be set as background

Change History

comment:1 Changed 9 years ago by dido

  • Category set to unknown
  • Analysis_score set to 0
  • Importance set to 60
  • Test_score set to 0
  • Design_score set to 0
  • Imp._score set to 0

comment:2 Changed 9 years ago by deni

  • Owner set to deni
  • Status changed from new to s1a_analysis_started
  • Changelog set to [wiki:Changelog]

comment:3 Changed 9 years ago by deni

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 9 years ago by deni

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Design_score changed from 0 to 3.5
  • If the padding is more that 15px, it will be included in the padding drop zone, too.
  • For consistency, the main resource of a frame will be changed if a resource is dropped over a frame view but outside the background drop zone.

comment:5 Changed 9 years ago by deni

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 9 years ago by deni

  • Status changed from s2a_design_started to s2b_design_finished
  • FrameView changes:
    • public static final int BACKGROUND_DROP_ZONE_WIDTH = 15;
    • public ImmRect getBackgroundDropZoneInnerRect() - gets the inner contour of the background drop zone of the frame view (in frame coordinates).
  • Make FrameView.ON_PRE_IMPORT_IMAGE_FOR_BACKGROUND and ResourceImportLogic.ON_PRE_IMPORT_RESOURCE_OVER_FRAME_CONTENT respect this zone.
  • RootPageView changes:
    • public static final int BACKGROUND_DROP_ZONE_WIDTH = 15;
    • public ImmRect getBackgroundDropZoneInnerRect() - inner contour of the background drop zone of this page view
  • Add a new operation in ScenePageView - ON_PRE_IMPORT_IMAGE_FOR_BACKGROUND that handles pre-importing images over the background drop zone of a page. For now, it handles events only if {@link ResourceRefData} is transferred.
    • It can use the same DropHandler that is used for frames.
  • The getBackgroundDropZoneInnerRect()s in FrameView and RootPageView cannot be moved in ElementView for two reasons:
    • Not all elements have background and it will be inappropriate for a view of an element without background to have a background drop zone.
    • The implementations are different - FrameView should respect the frame size and the padding while RootPageView should use the page size obtained from the book.

comment:7 Changed 9 years ago by deni

  • Status changed from s2b_design_finished to s2c_design_ok

comment:8 Changed 9 years ago by deni

  • Design_owners set to deni
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to deni
  • Analysis_reviewers set to debu

comment:9 Changed 9 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Done according to the design together with the tickets for DnD visual indication.
  • Source code: [8690] and [8697]

comment:10 Changed 9 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Analysis_reviewers debu deleted
  • Imp._reviewers set to meddle, todor
  • The hierarchy of the DropHandlers is changed.
    • BaseDropHandler is renamed to ResourceDropHandler.
    • There is extender to ResourceDropHandler -> ElementDropHandler which all the ElementDropHandler extend.
    • The hadleExit method of ResourceDropHandler does nothing.
    • The hadleExit method of the ElementDropHandler sets the indication to be invisible.

And the analysis score/review???

3.5p

comment:11 Changed 9 years ago by meddle

  • Cc deni added

comment:12 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.