Ticket #2311 (closed tweak: obsolete)

Opened 10 years ago

Last modified 8 years ago

dnd-page-reorder-visual – Add visual marker for reordering pages

Reported by: deyan Owned by: meddle
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc: tanya
Category: unknown Effort:
Importance: 60 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: tanya
Imp._owners: Test_owners:
Analysis_reviewers: tanya Changelog: Changelog
Design_reviewers: pap Imp._reviewers: meddle, todor, deyan
Test_reviewers: Analysis_score: 3
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description (last modified by deyan) (diff)

Add a visual marker that page is about to be dropped between other pages. Depends on #2310

Attachments

page_reordering_visualization.patch (20.7 KB) - added by tanya 10 years ago.
template_visualization.patch (10.1 KB) - added by tanya 10 years ago.
page_preview_thumb_over_separator.png (2.7 KB) - added by meddle 10 years ago.
Separator image

Change History

comment:1 Changed 10 years ago by deyan

  • Description modified (diff)

Batch update from file 2401.csv

comment:2 Changed 10 years ago by dido

  • Category set to unknown
  • Analysis_score set to 0
  • Importance set to 60
  • Test_score set to 0
  • Design_score set to 0
  • Imp._score set to 0

comment:3 Changed 10 years ago by deyan

  • Description modified (diff)

comment:4 Changed 10 years ago by tanya

  • Owner set to tanya
  • Status changed from new to s1a_analysis_started
  • Changelog set to [wiki:Changelog]

comment:5 Changed 10 years ago by tanya

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_reviewers set to tanya

comment:6 Changed 10 years ago by tanya

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3

comment:7 Changed 10 years ago by tanya

  • Design_owners set to tanya
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 10 years ago by tanya

  • PagePreviewPaletteCellRenderer will be deleted because is never used.
  • The PageItem panel has thumbnail panel, center panel and result panel. The thumbnail panel is in center panel and the center panel is in the result panel. The layout of the result panel will be set to border. The center panel will be added in the center part of the result. In the result panel will be added two more panels - one in north, the other in south part of the result panel. During drag'n'drop the north and the south panel will be skinned (painted green) to notify where the page will be dropped. When for example a page 3 is going to be dropped between pages 1 and 2, then the north panel of the second item will be skinned and will be painted green.When a page is going to be dropped after the last item, then the south panel of the last item will be painted green. Actually, the south panel only of the last item will be skinned when a page is going to be dropped after it. Otherwise the north panel of an item will be skinned.

comment:9 Changed 10 years ago by tanya

  • Status changed from s2a_design_started to s2b_design_finished

Changed 10 years ago by tanya

comment:10 Changed 10 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to pap
  • Seems accurate.
  • As I said I dislike the usage of the LaF xml but it seems that this cannot be done in another way.
  • Please have a look at dragging a page template between two pages in the PagePreviewPalette and add a visual indicator for that if it is not really hard.
  • Also as you are the analysis reviewer make sure that you write a comment explaining why do you score the analysis with the given mark.

comment:11 Changed 10 years ago by tanya

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 10 years ago by tanya

comment:12 Changed 10 years ago by tanya

  • Status changed from s3a_implementation_started to s3b_implementation_finished

+ In PagePreviewPalette two methods added - removeSeparators and visualizeSeparators, used when a template is going to be dropped between pages and in page reordering.

comment:13 Changed 10 years ago by tanya

+ two patches should be applied

comment:14 Changed 10 years ago by meddle

  • Cc tanya added
  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2.5
  • Imp._reviewers set to meddle
  • The patches can not be applied. Some of the handlers for the PagePreviewPalette which you rename/update are different now, I tried to apply it manually but I think I will break something. Update with the trunk and give me new patch
  • The binary resource page_preview_thumb_over_separator.png can not be found. You'll have to attach it here for example and say where it must be put.
  • Please update your trunk before giving patches, because otherwise we will have to fail tasks like that, and I don't like this too.

2.5p

Changed 10 years ago by meddle

Separator image

comment:15 Changed 10 years ago by meddle

  • Owner changed from tanya to meddle
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:16 Changed 10 years ago by meddle

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._score changed from 2.5 to 0

Returning to implementation finished...
There Experience team don't like the visual result though...

comment:17 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers changed from meddle to meddle, todor, deyan

Merged into the trunk at [8781].

  • Distances between page thumbnails are too big.
  • The user now can drag and drop the separators between page thumbnails.
  • The users can not scrow up/down when dragging (lack of autoscroll).
  • When there are more than one page on the book desktop, several green separators appear on other books.
  • You forgot the image for the separators.
  • There will be ticket about the spacings between the thumbnails.

3.5p

comment:18 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.