Ticket #2312 (closed tweak: obsolete)

Opened 15 years ago

Last modified 13 years ago

dnd-new-pages – Add ability to create new pages from a template

Reported by: deyan Owned by: deni
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 65 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: deni Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description

Dragging a page template to the page preview palette should create a new page from this template.

Attachments

dnd-new-templated-pages.patch (12.0 KB) - added by deni 15 years ago.

Change History

comment:1 Changed 15 years ago by dido

  • Category set to unknown
  • Analysis_score set to 0
  • Importance set to 65
  • Test_score set to 0
  • Design_score set to 0
  • Imp._score set to 0

comment:2 Changed 15 years ago by deni

  • Design_owners set to deni
  • Status changed from new to s1a_analysis_started
  • Imp._owners set to deni
  • Analysis_reviewers set to deni
  • Analysis_score changed from 0 to 4.5
  • Owner set to deni

comment:3 Changed 15 years ago by deni

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 15 years ago by deni

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Dragging a page template from the templates palette and dropping it over a page thumbnail will apply the template to the page over which it was dropped.
  • Dropping a template over the blank space between page templates will create a new page from the template.

comment:5 Changed 15 years ago by deni

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 15 years ago by deni

  • Status changed from s2a_design_started to s2b_design_finished
  • In PagePreviewPaletteLogic.ON_DND_APPLY_TEMPLATE we should check whether the template was dropped over a thumbnail or over the blank space between pages in order to decide what to do.
    • However, actually there isn't any blank space between the list items. The blank space is actually their padding.
    • I couldn't think of a proper way to check whether a point is in or outside the page thumbnail, because I can't convert its coordinates to the thumbnail's space.
    • I think it will be ok, if we consider blank the upper 10px and the bottom 10px of a list item. This will be very easy to check and seems to behave correctly.
  • Add a ResourceRefR4 argument to PagePreviewPaletteLogic.insertPage(EventR3, boolean) - a reference to the template that should be applied to the new page.
  • Add a ResourceRefR4 argument to BookView.addNewPage(int) - a reference to the template that should be applied to the new page.
    • If the ResourceRefR4 is not null or NONE_REF, it is preverred over the default page template, i.e. this is the template that is applied, even if there is a default template.
    • Maybe we should keep the addNewPage(int) and just add an overloaded version addNewPage(int, ResourceRefR4).
    • Make sure that creating a templated new page registers a single significant autoaction, so that undo behaves properly.
      • Creating a page will be done in a separate autoaction, which will be significant if no template will be applied.
      • Otherwise it will be insignificant. Applying the template will be registered in a significant autoaction.

comment:7 Changed 15 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • If the method is addNewPage and for creating and for templating a new page, why the AutoAction for the two is not a single significant one?
  • If the method addNewPage is used on a few places don't create two methods with different number of argument and fix the places where it is used.
  • About the 10px at the implementation review the Experience people will decide if it is a good idea...

3.5p

comment:8 Changed 15 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 15 years ago by deni

comment:9 Changed 15 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:10 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle

Merged to the trunk at [8662].

You an undocumented param, otherwise good one

4p

comment:11 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.