hud-tweaks

[deyan]

• Color subhuds appear where they should (vertical), but other subhuds appear at top (aligned with the main HUD). Make them appear aligned with the part of the HUD that is associated with it
• Gradient subhud does not have title
• Color subhud of the gradient HUD does not have close button
• Chaining HUD does not have title and close button
• Media HUD appears behind page resize halo
• Embedded book HUD should have „Embedded book“ title
• Embedded book HUD appears behind page resize halo

[stefan]

Analysis seems to be ok.

[stefan]

Design (following the analysis):

• Color subhuds appear where they should - the problem is in huds which have parents (hud's buttons) in HudTitleBar - the coordinates of the parent in its parent (hud's grandparent) are (0,0). Thats why the huds are on the top. The solution is in the HudDialog class, in the computeLocation() method (check if the grand parent of the hud is HudTitleBar - if so, take his coordinates):

  ...
  JComponent parentComponent = ((SwingVisualElement) parent().get()).swingComponent()
  						.get();
  if (parent().get().parent().get() != null &&
  	parent().get().parent().get() instanceof HudTitleBar) {
  		parentComponent = ((SwingVisualElement) parent().get().parent().get()).swingComponent().get();
  	}
  ...
  

• Gradient subhud does not have title - title is added
• Color subhud of the gradient HUD does not have close button - I couldn't solve this problem - for unknown (to me) reason, close button doesn't appear on the hud, although on every other place that the same hud is used, it does appear... Even when I hard-code change the visible() property in the close field, it does not have effect.
• Chaining HUD does not have title and close button - tittle and close button are added.
• Media HUD appears behind page resize halo - this is solved via reordering of the sort keys (the hud was also appearing underneath frameZOrderButton's, so that problem is also fixed.
• Embedded book HUD should have „Embedded book“ title - it is fixed.
• Embedded book HUD appears behind page resize halo - same as the media hud.

A patch for the task is uploaded.

[kyli]

The design seems OK, just:

• Instead of "parent().get().parent().get() != null && parent().get().parent().get() instanceof HudTitleBar", use "findParentElement(HudTitleBar.class) != null".
• By the way, "null instanceof HudTitleBar" will return false, so the null check in your code is not necessary. However, the solution from the previous point is better :)
• I don't think the problem with the "close" button is unsolvable, but I couldn't find a solution for it. Sorry for that.

3.5p

P.S. Please, add analysis score to this task.

[stefan]

implementation score attached as patch.

[meddle]

Merged into the trunk at [8961].

• The tool-tip for the embedded books hud was wrong, but that was the case in the trunk.
• The gradient's sub color picker still have no close button.
• Don't leave commented code that will be never used.

3.5p

[meddle]

Closing all the tickets before M Y1