client connectivity

[dido]

The goal of this task is to allow the user to log in to the server from Sophie Author and Reader.

• After the user selects server and press connect (or double click on a server) - Dialog window pops up. This will allow the user to identify himself. Fields for user name and password will appear as well as button for data submission.
  • This window will also provide "Log in as anonymous" functionality - this will happen with default value inside user name field (Anonymous) and empty password.
  • In case the server url is from type [user name]@[server url]. The default value of the user name filed should be the user name.
• Error or success notifications should appear next.
  • Error message should be "Something went wrong and Sophie was unable to connect to [server url]."
  • Success message should be "You have successfully connected to [server url]."
• Change the tooltip over the add button to say "Add connection" in order to be more consistent

Related: http://sophie2.org/trac/wiki/ServerOverview

[mira]

ServerConnection.connect() method

• After getting a sessionId from the server, show the ServerLoginDialog dialog.
• Try to login to the server with the given userName and pass. The dialog output is LoginInfo.
• If the login is successfull change the account of the ServerConnection. The AccountR4 keys.

[mira]

Design

Make createComponent() and a setUpExtra() methods in to be BoundTextField. They should be used by all classes that extend it. Make a BoundPasswordField that extends BoundTextField and just uses a JPasswordField as a text field.

• ServerLoginDialog

Make a dialog that will be prompted to the user when he/she is trying to connect to a server. It should contain three static inner classes:

• LoginInfo - This should be simple immutable class that contains two final strings - username and password. They should have public getters and modify methods that return new LoginInfo objects. This class should be used as a output of the ServerLoginDialog.
• Input - This class should extend DialogInput<LoginInfo>. It would be constructed by an account object and should provide method getLoginInfo(). This class should be used as a input of the ServerLoginDialog.
• SwingLoginDIalog - This class is used as the swing component for this dialog. it should have two inner classes: -- UserNameField - actual implementation of the BoundTextField, used to get the username used to connect to server. -- PasswordFiels - actual implementation of the BoundPasswordField, used to get the password to connect to the server.

Change the ServerConnection.connect() method. After getting a sessionId from the server, show the ServerLoginDialog dialog. Try to login to the server with the given userName and pass. If the login is successfull change the account of the ServerConnection. Review the AccountR4 keys.

To be able to download webui changes in TrueAuthor it should be able to resurect all used AutoActions in the web. For this they will be moved to a WebActionsUtil in the base.model.security module. Since it doed not depend on the func.images module the UserR4 should not use image resource as an avatar but a simple Key<ImmImage>. Make this key and remove the avatar ref from the users functionality.

[pap]

• Designs should be acompanied by some code related to them.
• No need to change ImageResource4 usage to ImmImage as ImageResource4 is in base.model.book module. You should've checked that.
• I think it is better to use resources as these would ease the implementation of other features.
• WebActionsUtil is not nice as a name and as an idea.
• Don't write fake JavaDoc, if the code is not to be documented now, just don't document it, beacause at the implementation phase it is possible to forget something undocumented.
• Update the lookandfeel xml files. First fix the java5 one to have the same definitions as that for java6. Also there are two bindings for PasswordFiled. One of them is unnecessary
• Also you mentioned quite briefly the way BoundPasswordField would be made. But you explained quite thoroughky simple immutables :)
• Don't change the port in the startServer() method. It should always call the other overload with the default port constant.

[mira]

The implementation is done according to the design with several alterations:

• I descided to keep the avatar image as resource and access it through the AVATAR_REF.
• I moved the auto-actions out of the webui module to the UserH (and discarded the WebActionsUtil idea). I think that people will look for them there.
• I moved the users directory name and ref to the UserR4, since for some reason the TrueAuthor could not find them from the servers.core.ServerResourceHelper
• I made the Accounts to keep only string userName, not ref.

• I moved the auto-actions out of the base.model.resources.r4 module since they were not loaded correctly and weren`t registered on the server.
• I fixed the bug #2363.

The implementation is at branches/private/mira/connectivity

[deyan]

Error or success notifications should appear next.

    * Error message should be "Something went wrong and Sophie was unable to connect to [server url]."
    * Success message should be "You have successfully connected to [server url]." 

These requirements are not met. Additionally, Anonymous user can be logged with any password, which is incorrect.

[deyan]

Also, Cancel and X button should only close the dialog without notifications.

[mira]

Both messages and cancel are fixed on the todors vnc where the task is merged.

[pap]

• Commited in [9090].
• In the whole chain of logic for connecting you used Boolean instead of boolean in order to have three states. This is not nice :)
• In BoundPasswordField instead of returning the default value if nothing is present in the skin, just return the skin value. Also add the default value in an initSkin method in the base class.
• Otherwise the task seems good.
• 3.5p

[meddle]

Closing all the tickets before M Y1