Ticket #2403 (closed tweak: obsolete)

Opened 15 years ago

Last modified 13 years ago

page-template-add-1 -- Add frames and groups inside page templates dialog

Reported by: deyan Owned by: boyanl
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: boyanl
Imp._owners: boyanl Test_owners:
Analysis_reviewers: boyanl Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 4
Test_score: 0

Description (last modified by deyan) (diff)

In addition to page options, add the following to the "Add template" dialog:

  • Element list (Groups and frames)
    • Element properties (list of properties for frames)
    • Sub element list (for composite elements such as groups)

For this revision of the task, nodes and how the tree looks are not essential - it is enough each element to be parent of its subelements and options.

Attachments

subelements_addition.patch​ (30.0 KB) - added by boyanl 15 years ago.

Change History

comment:1 Changed 15 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 15 years ago by deyan

  • Description modified (diff)

comment:3 Changed 15 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Description modified (diff)

comment:4 Changed 15 years ago by boyanl

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

OK

comment:5 Changed 15 years ago by boyanl

  • Analysis_reviewers set to boyanl
  • Analysis_score changed from 0 to 3.5

comment:6 Changed 15 years ago by boyanl

  • Owner changed from deyan to boyanl
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:7 Changed 15 years ago by boyanl

  • Design_owners set to boyanl
  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners set to boyanl
  • Changes to the TemplateInfo class:
    • Change the keyStates field to be a Map<ResourceRefR4, Map<Key<?>, Boolean> instead of a Map<Key<?>, Boolean> (to represent the keys that should be in the template for each element).
    • Add an ElementH rootElement field to store the root element of the tree.
    • Add a List<ResourceRefR4> field to store which elements should be removed from the template (includes their sub-elements which should be removed too).
  • Changes to the template dialog:
    • add an inner class NodeCacheKey, which is used as a key type for the map which stores the checknodes for every key ( keyMap, rename to keyToNodeMap ).
    • add a Map<ResourceRefR4, CheckNode> resourcesCheckNodes to store the check nodes for the root element/its sub-elements


  • Change the AddTemplateHaloButton's handler to pass the new parameters to TemplateUtil.createTemplate
  • Change TemplateUtil.createTemplate to accept new parameters - a map containing the keys for each ResourceRefR4 which should be excluded from the template and a list of ResourceRefR4s to be deleted from the template and modify the method to apply changes to keys of sub-elements/delete the required sub-elements.

comment:8 Changed 15 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • You should provide a patch/revision with design related code. Only reading plain text doesn't get us deep enough into the idea.
  • I think I understand what you'll do and support it, when I see the code, I would be able to write additional notes if I find something disturbing...

3p

comment:9 Changed 15 years ago by boyanl

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 15 years ago by boyanl

comment:10 Changed 15 years ago by boyanl

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:11 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, todor

Merged to the trunk at [9051].

  • Good.
  • But don't compare booleans as boolean_var != false, use !boolean_var

4p

comment:12 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.