auto-actions-improvements - See the wiki page in the ticket

[todor]

AutoActions

[tanya]

The analysis is not very detailed, but i think i got the idea.

[tanya]

Each AutoAction will be created this way

	new AutoAction(Message.create(KEY, Object...parameters), boolean significant)

parameters is a list of Objects and are the parameters for the KEY

KEY is a public final static String field. It will be equal or similar to the english version of the description of the AutoAction. Using the KEY, the description of the AutoAction will be skinned.

Class Message is created in org.sophie2.base.skins module in org.sophie2.base.skins package.

Message object has a method getText() that returns the description of the message. getText() returns string that depends on the current skin and is formated with String.format according the parameters.

[meddle]

• In the AppearanceHud key names as FRAME_SOMETHING are wrong, the messages are about all kind of elements, not just frames; Fix them. May be up to now, the messages were wrong too... So fix them and the JavaDoc as well.
  • In the ForgottenPasswordHandler you should import the Message class properly and not like this : new AutoAction(org.sophie2.base.skins.Message.create(CHANGE_PASS), true)
  • Message must be persistable, in other words to have immutable kind in the @Immutable annotation and a persister.
    • But you updated the ChangePersister, test working with the server, it could be possible that it is working, or you will have to modify that persister, instead of writing new.
    • Try uploading older book on the server, test for backward compatibility.
  • When you write asserts write messages to them, that way errors are tracked easier. See Message class.
  • Very good design for that task, the code is great documented as well

4p

[meddle]

Merged to the trunk at [9061].

• Very good.

4.5p

[meddle]

Closing all the tickets before M Y1