[server] Server related bugs

[meddle]

• BUG : When downloading book with images, sometimes assertation error is thrown.
• BUG : Pages and Frames with background images don't work. There is a BinSourceNotFound Exception.
• BUG : Sometimes there is a NullPointer when the download autorefreshes a not yet downloaded binary resource.
• BUG : Books with background images can not be saved and then reload.
• BUG : When a book is saved on the server and then the the client disconnects from it, the book is closed, but the user can still undo changes from this book, causing exceptions.
• BUG : When making changes with empty significant change (move, resize, apply page template) and then undo them, an error is thrown and the Database becomes unusable.
• BUG : There are some exceptions when using templates on server books.
• The DND bugs will be fixed later

[meddle]

Bug fixes:

• BUG : When downloading book with images, sometimes assertation error is thrown.
  • CAUSE : The images are being compared for some reason when the book is downloaded, so the exception is thrown because the equals worked with the size of the image, not its binary data. The problem was present only for background images...
  • FIX : The 'equals' method of the ImmImage now uses the size of the binary data, which is in the model, not get from the chunks.
• BUG : Pages and Frames with background images don't work. There is a BinSourceNotFound Exception.
  • CAUSE : The background images' binary source not found exceptions are not handled.
  • FIX : Handle them in ShapeElementHelper#drawContent(Graphics2D g2d) method, when there is now bin source found, the element will not be painted.
• BUG : Sometimes there is a NullPointer when the download autorefreshes a not yet downloaded binary resource.
  • CAUSE : For some reason after the event is dispatched the parent view of the ErrorManipulationView is removed (becomes null).
  • FIX : Remove the assert, and refresh only if the view is not null. FrameLogic
• BUG : Books with background images can not be saved and then reload.
  • CAUSE : The ref for these images is absolute.
  • FIX : Make the ref relative.
• BUG : When a book is saved on the server and then the the client disconnects from it, the book is closed, but the user can still undo changes from this book, causing exceptions.
  • CAUSE : The doc view of this book stays for some reason the current one...
  • FIX : Make the logic for removing the server books when disconnecting better. Now there is a boolean var, that is true only if the current doc view is server view, and if that is the case the current doc view becomes the desktop... It could be not the desktop but some other view, but the logic was that before (only not working :))
  • DUPLICATE : #2415
• BUG : When making changes with empty significant change (move, resize, apply page template) and then undo them, an error is thrown and the Database becomes unusable.
  • CAUSE : The database is made so that inly if there is setting of keys the revision new revision caused by the change is made the last one.
  • FIX : On the server side in the ResourceServiceDBImpl if there are no writes in the change, update the last revision caused by the empty change to be the last sync revision for the resource.
• BUG : There are some exceptions when using templates on server books.
  • I tried to reproduce them, but after fixing the problems with the background images I couldn't so they may be fixed... The default template bugfix should fix the one that when a book has default template and then is uploaded, there is exception... This is in the trunk, I guess, or in #2392.

[meddle]

server-bugfixes.patch

[meddle]

• The implementation is in the patch attached.
• I recommend this task be integrated before #2392, because it shorter, and patch conflicts are harder to resolve.
• It is present in the trunk of straxil:5

[pap]

• Commited in [9097].
• ShapeElementHelper - log in teh catch block, but with a low log level
• I should learn to look better for absolute refs - ImagePickerHud. Also we should at some point reconsider all refs in order to use server resourfces better.
• ImmImmmage - ok but I somewhat dislike that "compared for some reason" :)
• The current document fix - ok
• ResourceServiceDBImpl - OK
• ErrorManipulationView - ok but sounds strange...What is described means that the method gets called before it the view is attached. I don't see any other way for a null parent property.

[meddle]

Closing all the tickets before M Y1