Ticket #2430 (closed tweak: obsolete)

Opened 15 years ago

Last modified 13 years ago

immutable collections -- factory methods

Reported by: stefan Owned by: stefan
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group: immutable collections
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: stefan Design_owners: stefan
Imp._owners: stefan Test_owners:
Analysis_reviewers: pap Changelog: Changelog
Design_reviewers: meddle, pap Imp._reviewers: meddle, deyan
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description (last modified by stefan) (diff)

Since, at the moment there is only complex ways of creating immutable collections, there is need of creating factory methods with, as much as possible, simple arguments.

  • factory methods for creating hashing or non-hashing collection
  • factory methods for creating iterable collections with custom comparator.
  • factory methods for creating collection of another collection.

wiki page: IMM_COLLECTIONS_REFACTOR

Attachments

2430_de_fi.patch (27.9 KB) - added by stefan 15 years ago.
2430_im_fi.patch (28.1 KB) - added by stefan 15 years ago.

Change History

comment:1 Changed 15 years ago by stefan

  • Owner set to stefan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 15 years ago by stefan

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Description modified (diff)

comment:3 Changed 15 years ago by stefan

  • Description modified (diff)

comment:4 Changed 15 years ago by stefan

  • Ticket_group set to immutable collections

comment:5 Changed 15 years ago by stefan

  • Description modified (diff)

comment:6 Changed 15 years ago by pap

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to pap
  • Analysis_score changed from 0 to 3.5
  • OK

comment:7 Changed 15 years ago by stefan

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 15 years ago by stefan

  • Status changed from s2a_design_started to s2b_design_finished

А ImmCollectionUtil class is created. All of the standard factory methods are implemented: createXXX(), where XXX is List, Set, Map, etc. For Map there is also factory methods with or without map's key comparator. All of them are straight forward, so I won't be explaining any of them. Also factory methods for creating List and Set out of Collection are created. Code speaks for itself. Design related code in attached patch.

Changed 15 years ago by stefan

comment:9 Changed 15 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle, pap
  • Don't forget the five AutoActions. You should have listed them in the design...
  • Pap don't like the ImmCollectionUtil's name, I have no problem with it, so talk with him about that. He thinks that there are only 'create' methods there... but there is the indexOf... Don't know.

3.5p

comment:10 Changed 15 years ago by stefan

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 15 years ago by stefan

comment:11 Changed 15 years ago by stefan

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Not much changed - only the name of ImmCollectionUtil is changed to AccessCreateCollectionUtil

comment:12 Changed 15 years ago by meddle

  • Design_owners set to stefan
  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._owners set to stefan
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, deyan

Merged into the trunk at [9186].

And yet again, a lot of nothing to say...

comment:13 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.