cannot-turn-off-style -- Styles cannot be turned off without selection

[deyan]

Create a frame, start typing, press ctrl+i, type some italics text and try to switch off italics without selecting text

[deyan]

Batch update from file priorities8.csv

[diana]

The analysis is descriptive and good enough.

• In ImmHotText add a new function: private int getRunEnd(int i) - returns the last symbol of the current text after the given i-th one that has the same style as the i-th.
• In ImmHotText : replace optimize the function by using the getRunEnd - not all letters should use HotStyleDef.derive but the first one from every run.
• In HotStyleDef:equals change the function to return false if some of the attrs in the first HotStyleDef is not present in the map of the second one (needed because the inputStyle() property has not been updated properly).
• In TextModelLogic : ON_INSERT after inserting change the inpytStyle() to be HotStyleDef.getEmpty() - the input style is no longer considered for later insertion.
• In TextModelLogic : ON_SWITCH_STYLE check if the text is empty - otherwise an exception is thrown when trying to get the current style.

[meddle]

Failing due to behavior problems:

• The text formating changes are applied after you click in the frame, before that the styling is not dispalyed correctly.
• The style is applied, but the view is not refreshed before the user clicks in the frame??

2p

[diana]

• In ImmHotText:replace use the HotStyleDef:derive not replaceDerive function.
• In TextModelLogic:ON_SWITCH_STYLE if the selection is empty - set the inpytStyle() for this value to "not " the previous one (if the previous was true the new will be false and vice versa).

[pap]

• Committed in [9223].
• Tests should be named SomethingSomethingElseTest and not TestSomethingSomethingSomething
• Also they need real JavaDoc and not just an @author.
• Left commented out code in TextModelLogic.
• Inconsistency between hashCode and equals and getHash of HotStyleDef

[meddle]

Closing all the tickets before M Y1