Ticket #2438 (closed bug: obsolete)

Opened 10 years ago

Last modified 9 years ago

cannot-turn-off-style -- Styles cannot be turned off without selection

Reported by: deyan Owned by: diana
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 70 Ticket_group: text
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: diana Changelog: Changelog
Design_reviewers: meddle, pap Imp._reviewers: meddle, todor, todor, pap
Test_reviewers: Analysis_score: 3
Design_score: 3.5 Imp._score: 3
Test_score: 0

Description

Create a frame, start typing, press ctrl+i, type some italics text and try to switch off italics without selecting text

Attachments

2438.patch (12.9 KB) - added by diana 10 years ago.

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deyan

  • Importance set to 70

Batch update from file priorities8.csv

comment:3 Changed 10 years ago by diana

  • Design_owners set to diana
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to diana
  • Analysis_score changed from 0 to 3

The analysis is descriptive and good enough.

  • In ImmHotText add a new function: private int getRunEnd(int i) - returns the last symbol of the current text after the given i-th one that has the same style as the i-th.
  • In ImmHotText : replace optimize the function by using the getRunEnd - not all letters should use HotStyleDef.derive but the first one from every run.
  • In HotStyleDef:equals change the function to return false if some of the attrs in the first HotStyleDef is not present in the map of the second one (needed because the inputStyle() property has not been updated properly).
  • In TextModelLogic : ON_INSERT after inserting change the inpytStyle() to be HotStyleDef.getEmpty() - the input style is no longer considered for later insertion.
  • In TextModelLogic : ON_SWITCH_STYLE check if the text is empty - otherwise an exception is thrown when trying to get the current style.

comment:4 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s3b_implementation_finished

comment:5 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s1c_analysis_ok
  • Analysis_reviewers set to diana
  • Imp._reviewers set to meddle, todor
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 2

Failing due to behavior problems:

  • The text formating changes are applied after you click in the frame, before that the styling is not dispalyed correctly.
  • The style is applied, but the view is not refreshed before the user clicks in the frame??

2p

comment:6 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from s1c_analysis_ok to s2a_design_started
  • In ImmHotText:replace use the HotStyleDef:derive not replaceDerive function.
  • In TextModelLogic:ON_SWITCH_STYLE if the selection is empty - set the inpytStyle() for this value to "not " the previous one (if the previous was true the new will be false and vice versa).

comment:7 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s3b_implementation_finished

Changed 10 years ago by diana

comment:8 Changed 10 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from meddle to meddle, pap
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from meddle, todor to meddle, todor, todor, pap
  • Committed in [9223].
  • Tests should be named SomethingSomethingElseTest and not TestSomethingSomethingSomething
  • Also they need real JavaDoc and not just an @author.
  • Left commented out code in TextModelLogic.
  • Inconsistency between hashCode and equals and getHash of HotStyleDef

comment:9 Changed 9 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.