Ticket #2463 (closed bug: obsolete)

Opened 15 years ago

Last modified 13 years ago

auto-actions-named-classes--all

Reported by: diana Owned by:
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: auto_actions Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: pap Design_owners: pap
Imp._owners: pap, mira, diana Test_owners:
Analysis_reviewers: Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: meddle, deyan, todor
Test_reviewers: Analysis_score: 0
Design_score: 4 Imp._score: 4
Test_score: 0

Description

  • Extract all the anonymous classes from sophie2 non-test modules of type AutoAction in named classes in ".actions" packages in the same module.

Change History

comment:1 Changed 15 years ago by diana

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 15 years ago by diana

  • Status changed from s1b_analysis_finished to s2a_design_started
  • In org.sophie2.base.model.book module make new package org.sophie2.base.model.book.actions.base.
  • In the created package make two new classes:
    • public class SetKeyListAction extends AutoAction - An AutoAction that sets a list of Key-s to the values. This class has public constructor :

public SetKeyListAction(Message description, boolean significant, ImmList<Key<?>> keys, ImmList<Object> values) - Creates a SetKeyListAction.

  • public class SetKeyAction<T> extends AutoAction - An AutoAction that sets a given Key to a given value.<T> - The value type of the Key to set. This class has public constructor - public SetKeyAction(Message description, boolean significant, Key<T> key, T value) - Creates a SetKeyAction.
  • After creating these two classes some of the created named AutoAction classes in other modules can be removed.
  • Extract all other anonymous classes from non-test classes that cannot use SetKeyListAction and SetKeyAction in packages named ".actions" in their module.

comment:3 Changed 15 years ago by pap

  • Status changed from s2a_design_started to s3b_implementation_finished
  • Imp._owners changed from pap to pap, mira, diana

comment:4 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, deyan, todor
  • There was one strange test method in the textresourcehelper :)
  • I put some new lines at some places.
  • Good implementation.

Merged into the trunk at [9205].

4p

comment:5 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.