Ticket #375 (closed planned_task: obsolete)

Opened 12 years ago

Last modified 11 years ago

APP_FILE_DIALOGS_R0

Reported by: Astea Owned by: boyan
Priority: 3 Milestone: M02b_PRE2b
Component: APP_PLUGIN Version: 2.0
Keywords: Cc:
Category: unknown Effort: 0.5
Importance: 20 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: pav, pav Design_owners: kyli,kyli,peko,sasho
Imp._owners: boyan,pav Test_owners: danvisel
Analysis_reviewers: pap,pap Changelog:
Design_reviewers: pap, -tanya, boyan Imp._reviewers: meddle
Test_reviewers: deyan Analysis_score: 3
Design_score: 3 Imp._score: 3.5
Test_score: 3

Description

wiki page: APP_FILE_DIALOGS_R0 - effort: 0.5d

Change History

comment:1 Changed 12 years ago by pavlina

  • Owner changed from Astea to pavlina
  • Status changed from new to analyzing

comment:2 Changed 12 years ago by pavlina

  • Status changed from analyzing to analyzed

Pav (done: 20m)

comment:3 Changed 12 years ago by pap

  • Status changed from analyzed to new

Review 2. You should describe what file dialogs are(hint: look at the WBS file). They'll probably just provide extensions to the ep in base.dialogs module. Write a bit more explanatory overview :)

comment:4 Changed 12 years ago by pavlina

  • Status changed from new to analyzing

comment:5 Changed 12 years ago by pavlina

  • Status changed from analyzing to analyzed

done:20m

comment:6 Changed 12 years ago by pap

  • Status changed from analyzed to analysis_accepted

Review 3p. Sufficient

comment:7 Changed 12 years ago by deyan

  • Status changed from analysis_accepted to s1c_analysis_ok

repairing from invalid state

comment:8 Changed 12 years ago by kyli

  • Owner changed from pavlina to kyli
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 12 years ago by kyli

  • Status changed from s2a_design_started to s2b_design_finished

kyli(done:50m)

comment:10 Changed 12 years ago by pap

  • Status changed from s2b_design_finished to s1c_analysis_ok

Review: 2. These dialogs are part of main so the module should rather be org.sophie2.main.dialogs. Also, in my opinion, file dialogs alone are enough in quantity so they should rather be a part of a module containig more dialogs. The module should certainly provide extensions.

comment:11 Changed 12 years ago by kyli

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:12 Changed 12 years ago by kyli

  • Status changed from s2a_design_started to s2b_design_finished

must be ok now (15m)

comment:13 Changed 12 years ago by Tanya

  • Status changed from s2b_design_finished to s2c_design_ok

3p
OK

comment:14 Changed 12 years ago by milo

  • Status changed from s2c_design_ok to s1c_analysis_ok

2p - needs more

The design should at least provide list of the dialog classes that will be put in new module, and also some dependencies research (what depends on what).

Also it may be a better idea to create a module with the file menu related things, instead of just a module for dialogs. The idea of modules is to bundle things with related functionality, instead of related class things.

comment:15 Changed 12 years ago by deyan

  • Milestone changed from M02_PRE2 to M02b_PRE2b

Milestone change

comment:16 Changed 12 years ago by peko

  • Design_owners set to peko, sasho
  • Status changed from s1c_analysis_ok to s2a_design_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from kyli to peko
  • Imp._score set to 0

comment:17 Changed 12 years ago by peko

  • Status changed from s2a_design_started to s2b_design_finished

comment:18 Changed 12 years ago by boyan

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to boyan
  • Analysis_score changed from 0 to 3

You should have mentioned the name of the dialog containing the Inputs. The dependency diagram should also have been provided in the Design section, but you can do it while doing the implementation.

comment:19 Changed 12 years ago by boyan

  • Owner changed from peko to boyan
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to boyan

taken for implementation

comment:20 Changed 12 years ago by pavlina

  • Imp._owners changed from boyan to boyan, pav

comment:21 Changed 12 years ago by boyan

  • Design_owners changed from peko, sasho to peko,sasho
  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners changed from boyan, pav to boyan,pav,boyan

done (4.5 hours)

comment:22 Changed 12 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._reviewers set to meddle

The new package with the input dialogs is implemented; The dialogs are removed to it and converted from embedded static classes to public ones; The org.sophie2.func.file package now has two sub packages dialog and module and the FileDialog is moved in the org.sophie2.func.file.dialog, so OK for that revision.

comment:23 Changed 12 years ago by peko

  • Category set to unknown
  • Design_owners changed from peko,sasho to peko,sasho,peko

comment:24 Changed 12 years ago by tanya

  • Design_reviewers changed from boyan to boyan, tanya

comment:25 Changed 12 years ago by pap

  • Design_owners changed from peko,sasho,peko to kyli,kyli,peko,sasho
  • Design_reviewers changed from boyan, tanya to pap, -tanya, boyan
  • Imp._owners changed from boyan,pav,boyan to boyan,pav
  • Analysis_reviewers set to pap,pap
  • Analysis_owners set to pav, pav

setting custom fields

comment:26 Changed 11 years ago by danvisel

  • Status changed from s3c_implementation_ok to s4a_test_started
  • Test_owners set to danvisel

comment:27 Changed 11 years ago by danvisel

  • Status changed from s4a_test_started to s4b_test_finished
  • Test_score changed from 0 to 3

test passes.

comment:28 Changed 11 years ago by deyan

  • Status changed from s4b_test_finished to s4c_test_ok
  • Test_reviewers set to deyan

For revision 0, the test case passes. But, Choose File > Book Properties is not a file dialog. The test case should be splitted as it doesn't cover all of the functionality. In later revisions the following must be added: Different file dialogs offer different default file types, doubleclicking an item from the file dialog selects this file, does the action (default action for this dialog). Save triggers dialog only when book is modified and wasn't saved before.

comment:29 Changed 11 years ago by meddle

  • Imp._score changed from 0 to 3.5

Adding a mark for the implementation review.

comment:30 Changed 11 years ago by deyan

  • Status changed from s4c_test_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.