Ticket #536 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

BOOK_WINDOW_R1

Reported by: Astea Owned by: sriggins
Priority: 3 Milestone: M06_ALPHA1
Component: BOOK_VIEW Version: 2.0
Keywords: Cc: sriggins
Category: MAIN Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deyan,sriggins Design_owners: sriggins
Imp._owners: sriggins Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle,pap,pap Imp._reviewers: pap
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: BOOK_WINDOW_R1 - effort: 1d

Change History

comment:1 Changed 14 years ago by deyan

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to deyan
  • Imp._score set to 0
  • Analysis_owners set to deyan

comment:2 Changed 14 years ago by sriggins

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_owners changed from deyan to deyan,sriggins

comment:3 Changed 14 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 3

comment:4 Changed 14 years ago by sriggins

  • Design_owners set to sriggins
  • Owner changed from deyan to sriggins
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 14 years ago by sriggins

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 14 years ago by meddle

  • Cc sriggins, deyan, dido added
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle
  • Status changed from s2b_design_finished to s1c_analysis_ok

I will fail this design for the following reasons:

  • The design is not full. The analysis of a task has overview which describes the task and all of its revisions. The task requirements in other hand are for that revision and they have to be covered in the design. When you do analysis you have to say the requirements that you will cover at the current revision, and that is part of the analyzing. If somebody else is doing the analysis for you before the analysis is in state "finished" you have to see it and say for example "This requirement I can not do due to the time boxing". When the analysis is accepted, in the design you must give solutions or ideas for all the requirements of the task.
  • You have to provide tests for the design of this task, it is rear for us to pass a task without tests in the design section (example for such tasks are process, performance, SCS tasks...).
  • When something (the PageWorkArea positioning) is decided in the analysis, it can be changed in the design, the design have to be according to the analysis if the analysis is passed! If you want I will super review this task and will revert it to status "new". Then you will have the opportunity ti change the analysis and give it to us for review.

2p (1h)

comment:7 Changed 14 years ago by meddle

  • Status changed from s1c_analysis_ok to new

Super review to status new for Steve.

comment:8 Changed 14 years ago by sriggins

  • Status changed from new to s1a_analysis_started

comment:9 Changed 14 years ago by sriggins

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:10 Changed 14 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 3 to 3.5

It will be nice if in full screen mode the title bar does not present. However this could be part of the full screen task.
Analysis review 3.5p (30min)

comment:11 Changed 14 years ago by sriggins

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:12 Changed 14 years ago by sriggins

  • Status changed from s2a_design_started to s2b_design_finished

comment:13 Changed 14 years ago by pap

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_reviewers changed from meddle to meddle,pap
  • 1. OK
  • 2. Sounds sensible in some way
  • 3. That is not right
  • 4. I do not like that. The idea is taht the Page work area is in the center of the book window, * and not to resize it according to the book window
  • 5. Sounds OK.
  • The test does not seem very sensible, but I cannot say if it can be.
  • The test should be in the Design section. The Testing part of the wiki page is about the last phase of a ticket.

comment:14 Changed 14 years ago by sriggins

pap, re:4 the page work area is not resized, but it does set the minimalViewRect on the scene, which the page work area tracks. The scene then centers itself upon rendering. The page work area listens to the window resizing (via the windowSize changing) and then decides how big the scene should be, minimally. Milo wanted me to reach up, not down, so the book document window doesn't know anything about page work areas.

re: test, that test was done because it was commented by peko that it needed to be done with the BookWindow task. Could you suggest a better test? It was difficult to find where to do other tests and how to do them for UI classes (and verify the UI worked)

comment:15 Changed 14 years ago by sriggins

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:16 Changed 14 years ago by sriggins

pap: re: 3, I had re-done that design after I submitted it but didn't know what the process was to changing a design after it was submitted, so I updated it now

comment:17 Changed 14 years ago by sriggins

  • Status changed from s2a_design_started to s2b_design_finished

comment:18 Changed 14 years ago by sriggins

  • Imp._owners set to sriggins

comment:19 Changed 14 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3
  • Design_reviewers changed from meddle,pap to meddle,pap,pap
  • I accept the design although I doubt in some of its approaches.
  • I will do further reviewing when I see the implementation
  • Make sure to synchronize the implementation with the current condition of the trunk, especially with the changes coming from the full screen task(ask for help if you need to)
  • Also try not to break working functionality. If you do so you should either fix it or point that out and explain why it cannot be fixed in this task.

comment:20 Changed 14 years ago by sriggins

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:21 Changed 14 years ago by sriggins

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:22 Changed 14 years ago by pap

  • Cc boyan added; deyan, dido removed
  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to pap

I let this task pass because I consider some of the results valuable. Otherwise what was done had several issues.

  • It doen't fullfil all the requirements
  • The last commit does strange things. I used it only partialy.
  • You seem to be changing more than what is necessary.
  • I had to do several reworks of your job. Plеаsе see the trunk changeset.

Totally spent about 16 hours on de and im reviews and reworks of this task.

comment:23 Changed 14 years ago by boyan

  • Cc boyan removed

cc removed

comment:24 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.