BOOK_WINDOW_R1

[Astea]

wiki page: BOOK_WINDOW_R1 - effort: 1d

[meddle]

I will fail this design for the following reasons:

• The design is not full. The analysis of a task has overview which describes the task and all of its revisions. The task requirements in other hand are for that revision and they have to be covered in the design. When you do analysis you have to say the requirements that you will cover at the current revision, and that is part of the analyzing. If somebody else is doing the analysis for you before the analysis is in state "finished" you have to see it and say for example "This requirement I can not do due to the time boxing". When the analysis is accepted, in the design you must give solutions or ideas for all the requirements of the task.
• You have to provide tests for the design of this task, it is rear for us to pass a task without tests in the design section (example for such tasks are process, performance, SCS tasks...).
• When something (the PageWorkArea positioning) is decided in the analysis, it can be changed in the design, the design have to be according to the analysis if the analysis is passed! If you want I will super review this task and will revert it to status "new". Then you will have the opportunity ti change the analysis and give it to us for review.

2p (1h)

[meddle]

Super review to status new for Steve.

[dido]

It will be nice if in full screen mode the title bar does not present. However this could be part of the full screen task.
Analysis review 3.5p (30min)

[pap]

• 1. OK
• 2. Sounds sensible in some way
• 3. That is not right
• 4. I do not like that. The idea is taht the Page work area is in the center of the book window, * and not to resize it according to the book window
• 5. Sounds OK.
• The test does not seem very sensible, but I cannot say if it can be.
• The test should be in the Design section. The Testing part of the wiki page is about the last phase of a ticket.

[sriggins]

pap, re:4 the page work area is not resized, but it does set the minimalViewRect on the scene, which the page work area tracks. The scene then centers itself upon rendering. The page work area listens to the window resizing (via the windowSize changing) and then decides how big the scene should be, minimally. Milo wanted me to reach up, not down, so the book document window doesn't know anything about page work areas.

re: test, that test was done because it was commented by peko that it needed to be done with the BookWindow task. Could you suggest a better test? It was difficult to find where to do other tests and how to do them for UI classes (and verify the UI worked)

[sriggins]

pap: re: 3, I had re-done that design after I submitted it but didn't know what the process was to changing a design after it was submitted, so I updated it now

[pap]

• I accept the design although I doubt in some of its approaches.
• I will do further reviewing when I see the implementation
• Make sure to synchronize the implementation with the current condition of the trunk, especially with the changes coming from the full screen task(ask for help if you need to)
• Also try not to break working functionality. If you do so you should either fix it or point that out and explain why it cannot be fixed in this task.

[pap]

I let this task pass because I consider some of the results valuable. Otherwise what was done had several issues.

• It doen't fullfil all the requirements
• The last commit does strange things. I used it only partialy.
• You seem to be changing more than what is necessary.
• I had to do several reworks of your job. Plеаsе see the trunk changeset.

Totally spent about 16 hours on de and im reviews and reworks of this task.

[boyan]

cc removed

[deyan]

Batch update from file query-obsoleted.csv