Ticket #587 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PAGE_SELECTOR_R0

Reported by: Astea Owned by: peko
Priority: 3 Milestone: M02b_PRE2b
Component: BOOK_PAGES Version: 2.0
Keywords: Cc:
Category: unknown Effort: 0.5
Importance: 20 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: pap Design_owners: peko
Imp._owners: peko Test_owners: danvisel
Analysis_reviewers: todor Changelog:
Design_reviewers: pap Imp._reviewers: sriggins, pav,boyan,boyan,tanya
Test_reviewers: deyan Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 3

Description

wiki page: PAGE_SELECTOR_R0 - effort: 0.5d

Change History

comment:1 Changed 14 years ago by todor

  • Owner changed from Astea to todor
  • Status changed from new to analyzing

comment:2 Changed 14 years ago by todor

  • Status changed from analyzing to analyzed

comment:3 Changed 14 years ago by todor

  • Status changed from analyzed to analysis_accepted

comment:4 Changed 14 years ago by peko

  • Owner changed from todor to peko
  • Status changed from analysis_accepted to designing

comment:5 Changed 14 years ago by peko

  • Status changed from designing to designed

comment:6 Changed 14 years ago by pap

  • Status changed from designed to design_accepted

Review: 3 by Pap. It's not mentioned how will the page selector perform navigation. It'd be good for the design to mention what are the relations of the page selector with other parts of the application. How does it connect to the book in order to change pages?

comment:7 Changed 14 years ago by peko

  • Status changed from design_accepted to implementing

comment:8 Changed 14 years ago by peko

  • Status changed from implementing to implemented

comment:9 Changed 14 years ago by milo

  • Status changed from implemented to s3b_implementation_finished

comment:10 Changed 14 years ago by Tanya

  • Status changed from s3b_implementation_finished to s2c_design_ok

2p
It is OK, but there are some things that could be better:
1) Page selector and navigation panel are the same - it is a bit confusing.
2) Not enough unit tests (actually i am not sure if there are any).
3) In the implementation part in the wiki page it is not linked neither to the .java files, nor to changesets - sometimes it is impediment to find which classes are of interest to you (for reviewing for example)

comment:11 Changed 14 years ago by peko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:12 Changed 14 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:13 Changed 14 years ago by deyan

  • Milestone changed from M02_PRE2 to M02b_PRE2b

Milestone change

comment:14 Changed 14 years ago by sriggins

  • Design_score set to 0
  • Imp._reviewers set to sriggins
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:15 Changed 14 years ago by pavlina

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._owners set to Peko
  • Imp._reviewers changed from sriggins to sriggins, Pavlina

There is no links to the implementation classes(or to the changeset). It is impediment for the review(see p.3 of the previous review)

comment:16 Changed 14 years ago by peko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:17 Changed 14 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:18 Changed 14 years ago by boyan

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers changed from sriggins, Pavlina to sriggins, Pavlina,boyan

You still haven't linked the changeset. Read PLATFORM_STANDARDS_GENERAL. Reviews are difficult to make with no link to the source code changed. Follow the standards! "Done according to the design" is not enough for the implementation section.

comment:19 Changed 14 years ago by peko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:20 Changed 14 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:21 Changed 14 years ago by boyan

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from sriggins, Pavlina,boyan to sriggins, Pavlina,boyan,boyan

It is OK, but seems that the last two changesets are not related to the Page Selector but to the Book Panel that contains it.

comment:22 Changed 14 years ago by peko

  • Category set to unknown
  • Design_owners set to peko
  • Imp._owners changed from Peko to peko

comment:23 Changed 14 years ago by tanya

  • Imp._reviewers changed from sriggins, Pavlina,boyan,boyan to sriggins, Pavlina,boyan,boyan,tanya

comment:24 Changed 14 years ago by pap

  • Design_score changed from 0 to 3
  • Design_reviewers set to pap
  • Analysis_reviewers set to todor
  • Analysis_owners set to pap
  • Analysis_score changed from 0 to 3

setting some custom fields

comment:25 Changed 14 years ago by danvisel

  • Status changed from s3c_implementation_ok to s4a_test_started

comment:26 Changed 14 years ago by danvisel

  • Status changed from s4a_test_started to s4b_test_finished
  • Test_score changed from 0 to 3

comment:27 Changed 14 years ago by danvisel

  • Test_owners set to danvisel

comment:28 Changed 14 years ago by deyan

  • Status changed from s4b_test_finished to s4c_test_ok
  • Test_reviewers set to deyan

test ok, not sure if next button in page selector will be used for creating new page - it is useful in my opinion (part of the documentation). So-called border cases should be added, when in the page field are typed numbers or spaces, etc. These things should be defined in specification of this task in Task Index.

comment:29 Changed 13 years ago by deyan

  • Imp._reviewers changed from sriggins, Pavlina,boyan,boyan,tanya to sriggins, pav,boyan,boyan,tanya

Batch update from file newimport.csv

comment:30 Changed 13 years ago by deyan

  • Status changed from s4c_test_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.