Ticket #756 (closed planned_task: obsolete)

Opened 11 years ago

Last modified 10 years ago

FRAME_ROTATION_R1

Reported by: Astea Owned by: sriggins
Priority: 3 Milestone: M07_ALPHA2
Component: FRAME_PROPERTIES Version: 2.0
Keywords: Cc:
Category: MAIN Effort: 1.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: sriggins, dido Design_owners: sriggins
Imp._owners: sriggins Test_owners:
Analysis_reviewers: Changelog:
Design_reviewers: mira Imp._reviewers:
Test_reviewers: Analysis_score: 3
Design_score: 1 Imp._score: 0
Test_score: 0

Description

wiki page: FRAME_ROTATION_R1 - effort: 1.5d

Change History

comment:1 Changed 10 years ago by sriggins

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to sriggins
  • Imp._score set to 0
  • Analysis_owners set to sriggins

comment:2 Changed 10 years ago by dido

  • Analysis_owners changed from sriggins to sriggins, dido

comment:3 Changed 10 years ago by sriggins

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 10 years ago by deyan

  • Status changed from s1b_analysis_finished to new
  • Analysis_score changed from 0 to 1

The analysis is very unclear to me. What is the rectangle on the first attachment? Is it recalculated after the rotation? Where is the rotating point after mouse drop, is it's position recalculated? Same goes for the second picture.

  • The initial position of the halo button is equal by degrees to the first selected frame. (If for example the first selected frame has rotation 45 degree then the halo button is moved 45 degrees from the center of the selection rectangle) Can you explain that further? Couldn't understand much of this.

comment:5 Changed 10 years ago by dido

  • Owner changed from sriggins to dido
  • Status changed from new to s1a_analysis_started

Add some changes as well as descriptions of the diagrams. Hope it clear enough.
Analysis 1h

comment:6 Changed 10 years ago by dido

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:7 Changed 10 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 1 to 3

I don't like the frames' top left point to be center of the rotation. However, this will be static, won't it? When the frame is rotated at 180 degrees, the top left point will be bottom left, right?

comment:8 Changed 10 years ago by sriggins

  • Design_owners set to sriggins
  • Owner changed from dido to sriggins
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 10 years ago by sriggins

  • Status changed from s2a_design_started to s2b_design_finished

comment:10 Changed 10 years ago by sriggins

  • Imp._owners set to sriggins

comment:11 Changed 10 years ago by mira

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 1
  • Design_reviewers set to mira

When writing a design you should only describe how something should be implemented not as a retrospection of what you have done. All design related code should be provided.

If ROTATE_TO is a new enum the FrameRotateLogic can not implement it. You should use proper terminology so that anyone can understand the design. I guess you mean that a new element should be added to the FrameRotateLogic enum and it is named ROTATE_TO. This name is not appropriate. Further more I don`t think you should have two operations doing the same think "just in case some code is resurrected".

Names like FrameRotationPropertiesHud or FrameDragRotatePropertiesHaloButton are two long and confusing.

You should be very careful when adding methods to abstract classes like MouseCapture since this method will be added to all descendants. Maybe it is better to add the method to your concrete implementation.

To pass the design you should have good tests. You may try to fire events for drag and drop of the halo and if you still need the actual halo you can write a SystemTest.

Since there is grouping of frames now it is good to realize the optional part of the task requirements.

comment:12 Changed 10 years ago by deyan

  • Status changed from s1c_analysis_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.