Ticket #943 (closed planned_task: obsolete)
WRAPPING_TEXT_RENDERING_R1
| Reported by: | Astea | Owned by: | vlado |
|---|---|---|---|
| Priority: | 3 | Milestone: | M06_ALPHA1 |
| Component: | TEXT_RENDERING | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | MAIN | Effort: | 1.5 |
| Importance: | 0 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | vlado, vlado | Design_owners: | vlado, vlado |
| Imp._owners: | vlado | Test_owners: | |
| Analysis_reviewers: | Changelog: | ||
| Design_reviewers: | meddle, meddle | Imp._reviewers: | pap, meddle |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
wiki page: WRAPPING_TEXT_RENDERING_R1 - effort: 1.5d
Change History
comment:1 Changed 16 years ago by vlado
- Status changed from new to s1a_analysis_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from Astea to vlado
- Imp._score set to 0
- Analysis_owners set to vlado
comment:2 Changed 16 years ago by vlado
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to new
- Analysis_score changed from 0 to 2
More specifications are needed inside task requirements section
Analysis review 2p (30m)
comment:4 Changed 16 years ago by vlado
- Status changed from new to s1a_analysis_started
- Analysis_owners changed from vlado to vlado, vlado
comment:5 Changed 16 years ago by vlado
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:6 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_score changed from 2 to 4
Analysis review 4p (30m)
comment:7 Changed 16 years ago by vlado
- Design_owners set to vlado
- Status changed from s1c_analysis_ok to s2a_design_started
comment:8 Changed 16 years ago by vlado
- Status changed from s2a_design_started to s2b_design_finished
comment:9 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s1c_analysis_ok
- Design_score changed from 0 to 2
- Design_reviewers set to meddle
- When you write design write the new classes/methods that you will add or the old one that you will change!
- There is no method "HotTextSceneElementImpl.testLayout()" you are talking about the "HotTextSceneElementImpl.textLayout()" method, fix this line...
- I think detailed JUnit test about the layout algorithm is needed here. Only the demo is not enough.
- And please describe with more details the area things... You can have method that returns the area of those frameviews that has grater z-order than the current. That when you substract that area from the current frameview's area you will have the layout area... If that is your idea I like it, if it's not you describe why it's better, because from what you wrote I don't understand what you meant.
2p (30m)
comment:10 Changed 16 years ago by vlado
- Design_owners changed from vlado to vlado, vlado
- Status changed from s1c_analysis_ok to s2a_design_started
comment:11 Changed 16 years ago by vlado
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 2 to 3
- Design_reviewers changed from meddle to meddle, meddle
- Code related notes:
- Why do you have System.out.println("Text demo started in " (double) totalStartupTime / 1000 + " sec."); in the demo?? Remove it.
- Design related notes:
- And yet again you tell that you will collect the areas and substract them but you don't give methods and classes where you will do that!
- You added a link to the test :)
The design passes with 3p (15m)
comment:13 Changed 16 years ago by vlado
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to vlado
comment:14 Changed 16 years ago by vlado
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:15 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3.5
- Imp._reviewers set to pap, meddle
- Generally good but there were some bugs that had to be fixed on the fly
- The sizes of the frames were not calculated correctly - some accent problems.
- The DeletePos class was not immutable
- Additionally fixed a bug with the text styling hud.
- You tend to write too long lines of code. These don't look nice ot not so wide monitors.
- We like that you put useful comments in your code.
comment:16 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
