Ticket #942 (closed planned_task: obsolete)
WRAPPING_TEXT_RENDERING_R0
Reported by: | Astea | Owned by: | vlado |
---|---|---|---|
Priority: | 3 | Milestone: | M04_PRE4 |
Component: | TEXT_RENDERING | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | MAIN | Effort: | 2.5 |
Importance: | 0 | Ticket_group: | |
Estimated Number of Hours: | Add Hours to Ticket: | ||
Billable?: | Total Hours: | ||
Analysis_owners: | dido, vlado, vlado | Design_owners: | vlado |
Imp._owners: | vlado | Test_owners: | |
Analysis_reviewers: | deyan,deyan | Changelog: | |
Design_reviewers: | meddle | Imp._reviewers: | meddle |
Test_reviewers: | Analysis_score: | 3.5 | |
Design_score: | 3 | Imp._score: | 3 |
Test_score: | 0 |
Description
wiki page: WRAPPING_TEXT_RENDERING_R0 - effort: 2.5d
Change History
comment:1 Changed 16 years ago by dido
- Status changed from new to s1a_analysis_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from Astea to dido
- Imp._score set to 0
- Analysis_owners set to dido
comment:2 Changed 16 years ago by dido
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to new
Batch update from file query-1.csv
comment:4 Changed 16 years ago by vlado
- Owner changed from dido to vlado
- Status changed from new to s1a_analysis_started
- Analysis_owners changed from dido to dido, vlado
comment:5 Changed 16 years ago by vlado
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:6 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to new
- Analysis_reviewers set to deyan
- Analysis_score changed from 0 to 2.5
I think wrapping depends on z-order of the frame, if text's frame z-order is higher, the text should not wrap. Also, where these wrap options will be? In which HUD?
comment:8 Changed 16 years ago by vlado
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:9 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers changed from deyan to deyan,deyan
- Analysis_owners changed from dido, vlado to dido, vlado, vlado
- Analysis_score changed from 2.5 to 3.5
Adding a new HUD may not be the best solution. In design reconsider where to put this.
comment:10 Changed 16 years ago by vlado
- Design_owners set to vlado
- Status changed from s1c_analysis_ok to s2a_design_started
comment:11 Changed 16 years ago by vlado
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to meddle
I think that design is OK for the tasks requirements. There were some code quality problems with the test and the code, I fixed them, for the future take a look here GoodCodeExamples.
3p ()
comment:13 Changed 16 years ago by vlado
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to vlado
comment:14 Changed 16 years ago by vlado
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:15 Changed 16 years ago by meddle
- Cc vlado added
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3
- Imp._reviewers set to meddle
- Code problems:
- You left some "System.out.println(...);" statements in your LayoutBuilderTest and EdgeKind... I will remove them, but in the future remove them yourself!
- The assertEquals method has special parameters, the first one is the EXPECTED one, and the second one the ACTUAL one. Write you tests using that convention!
- Write your name as an author if you change the logic or the structure of a class.
- Fake JavaDoc???
/** * Draws the specified source {@link Vertex} of the edge to * {@link Graphics2D}. * * @param g2d * The {@link Graphics2D} to draw to. * @param sourceState * The source {@link Vertex} to draw * @param caretBefore * @param selected */ public void draw(Graphics2D g2d, Vertex sourceState, boolean caretBefore, boolean selected) { //do nothing by default }
comment:17 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.