ANNOTATIONS_EXPORT_IMPORT_R1

[Astea]

wiki page: ANNOTATIONS_EXPORT_IMPORT_R1 - effort: 2d

[mitex]

analysis started

[meddle]

• Design notes:
  • The design is not clear for this things:
    • How do you understand if the file is valid, you look the resource type from the storage? Because if the file is Sophie book it will be valid resource saved in file... How do you make the difference?
    • You may use different extension than "sjrb" for your files, but consult with Milo about this.
• Code notes:
  • You create resources wrongly, you must give their parent resources on create.
  • This printStorage method in your test must use the logger if it's not commented... don't give us code with sysos on the design or implementation stage

3.5p (35m)

[meddle]

I'll fail the two annotation tasks because they are not tested and are not synchronized with the trunk.

2.5p (15m)

[meddle]

• Behavior related notes:
  • You broke the true reader... There is an exception when it is started:

    Exception in thread "AWT-EventQueue-0" java.lang.NoClassDefFoundError: org/sophie2/main/app/halos/page/element/PageElementMoveHaloButton
    	at java.lang.ClassLoader.defineClass1(Native Method)
    	at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
    	at org.apache.felix.framework.searchpolicy.ContentClassLoader.findClass(ContentClassLoader.java:214)
    	at org.apache.felix.framework.searchpolicy.ContentClassLoader.loadClassFromModule(ContentClassLoader.java:85)
    	at org.apache.felix.framework.searchpolicy.ContentLoaderImpl.getClass(ContentLoaderImpl.java:141)
    	at org.apache.felix.framework.searchpolicy.R4Wire.getClass(R4Wire.java:101)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.searchImports(R4SearchPolicyCore.java:507)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.findClassOrResource(R4SearchPolicyCore.java:468)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.findClass(R4SearchPolicyCore.java:187)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicy.findClass(R4SearchPolicy.java:45)
    	at org.apache.felix.framework.searchpolicy.ContentClassLoader.loadClass(ContentClassLoader.java:109)
    	at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
    	at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
    	at org.sophie2.extra.func.annotations.AnnotationsModule.defineExtensions(AnnotationsModule.java:96)
    	at org.sophie2.core.modularity.SophieModule$3.run(SophieModule.java:66)
    	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
    	at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
    	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
    	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
    	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
    	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
    	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
    	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
    Caused by: java.lang.ClassNotFoundException: org.sophie2.main.app.halos.page.element.PageElementMoveHaloButton
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.findClass(R4SearchPolicyCore.java:200)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicy.findClass(R4SearchPolicy.java:45)
    	at org.apache.felix.framework.searchpolicy.ContentClassLoader.loadClass(ContentClassLoader.java:109)
    	at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
    	at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
    	... 23 more
    Caused by: java.lang.ClassNotFoundException: org.sophie2.main.app.halos.page.element.PageElementMoveHaloButton
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.findClassOrResource(R4SearchPolicyCore.java:488)
    	at org.apache.felix.framework.searchpolicy.R4SearchPolicyCore.findClass(R4SearchPolicyCore.java:187)
    	... 27 more
    

    • That is caused because you moved the halo button up in the hierarchy, but didn't add it's module to the bundle configuration of the reader. But if you add it, you will make a huge mistake, because the frames in the reader will be moveble! This thing must be fixed for this task to pass!
  • In the reader now there is now extra palette... But the stickies are mostly for the reader and the preview.
  • In the preview mode the stickies are insertable. which is good, they are editable, which is also good, but they are not moveable and deletable, which is bad. The stickies are used mostly in preview modes and readers!
  • The unusable buttons in the extra palette must be disabled until they are useable.
• Code related notes:
  • The point of having ONE method persist() is to have consistent logic for both modes - save and load. You should not use the value refs if you don`t override the getInnitial() method. This forces you to divide the save/load logic. Further more there is no point in using

    Ref<String> entityRef = new ValueRef<String>() {
    // nothing
    };
    

when it is obvious that you could simply use new ValueRef<String>().

• You should move the

  String searchPath = file.getAbsolutePath();
  
  if (!File.separator.equals(Resource.LOCATION_SEPARATOR)) {
      int index = searchPath.lastIndexOf(File.separator);
      if (index != -1) {
         searchPath = searchPath.substring(0, index)
            + searchPath.substring(index, searchPath.length()).replace(File.separator, Resource.LOCATION_SEPARATOR);
      }
  }
  

in a untill class and not repeat the same code.

• The many TODO and FIXME show that you know the problems but you still didn`t fix them.
• What the hell is that -> storage.debugPrint(0); in your final code???
• Refactor your StickyRemoveButton to send events to the StickyLogic, not to delete the stickies itself.

2p (150m)

[meddle]

After a while and with big refactoring from the integrators ready.

3p (110m)

[deyan]

Batch update from file query-obsoleted.csv