wiki:UNPLANNED_UNIT_TEST_FIX_R0

Version 11 (modified by kyli, 16 years ago) (diff)

--

Error: Macro BackLinksMenu(None) failed
compressed data is corrupt

Error: Macro TicketQuery(summary=UNPLANNED_UNIT_TEST_FIX_R0, format=table, col=summary|owner|status|type|component|priority|effort|importance, rows=description|analysis_owners|analysis_reviewers|analysis_score|design_owners|design_reviewers|design_score|implementation_owners|implementation_reviewers|implementation_score|test_owners|test_reviewers|test_score|) failed
current transaction is aborted, commands ignored until end of transaction block

Analysis

Overview

Automatic tests need to be improved. Latest Hudson build reports 288 test failures out of 962 tests.

Task requirements

  • Revise the current unit tests
  • Remove any useless test cases (for more, see implementation idea).
  • Make as much as possible tests / demos to work. This includes improving the source if tests report problems.
  • Writing new tests is not required for this revision, since it is too much effort.

Task result

Removed useless tests, others - passing.

Implementation idea

  • Read about how to write good unit tests, PLATFORM_STANDARDS_AUTO_TESTS for documented convensions for testing and "Code smells" in the internal backlog. Look also at the available demos.
  • Describe what needs to be removed, what will be repaired and what tests need to be written during the next revision.
  • Use FakeModuleRegistry where you need to use extension points.

PLATFORM_STANDARDS_AUTO_TESTS

How to demo

Run all the available tests (through Eclipse, right click sophie2-platform, run as.., maven test).

Design

  • While refactoring tests, look for the following things:
    • Tests should UnitTestBase or IntegrationTestBase
    • All resources needed for tests should be placed in the /src/test/resources folder of the module where the test is in
    • Remove testing of simple getters
    • Repair fake JavaDoc
    • Where ither modules are needed, use FakeModuleRegistry.start(). In this case, make the class extend IntegrationTestBase. Look specifically at the modules ewhich have to be started, this is a common mistake.
    • Take care for "TODO: refactor" things.
    • Remove "fail('not implemented')" methods.
    • Refactor any "try{fail();} catch(Throwable){}" statements, since they are useless. Fix the errors that will appear after refactoring them.
    • Either refactor commented tests, or delete them.
    • Look for the correct place of each test - if incorrect, fix it.
  • Here is a list of the current modules and what has to be changed there :
org.sophie2.base.boundrefactor
org.sophie2.base.commonsrefactor
org.sophie2.base.connectivitynothing - no tests
org.sophie2.base.dialogsDialogManagerTest must be DialogManagerDemo, it should run
org.sophie2.base.halosrefactor
org.sophie2.base.layoutBaseLayoutDemo is actualy a test; needs to refactor
org.sophie2.base.medianothing - no tests
org.sophie2.base.menusrefactor
org.sophie2.base.model.bookthoroughly refactor/delete GroupTest, review the others.
org.sophie2.base.model.resourcesnothing - OK
org.sophie2.base.model.textnothing - the demo is OK
org.sophie2.base.persistencemany try-catch mistakes, refactor
org.sophie2.base.sceneDelete SceneTest2, revire the demo.
org.sophie2.base.skinsnothing - no tests
org.sophie2.base.visualnothing - OK
org.sophie2.corerefactor
org.sophie2.core.modularityreview - add super.setUp() to setUp methods
org.sophie2.core.mvcreview - Decide whether no view should not be handled (TestDemo2)
org.sophie2.extra.func.annotationsnothing - OK
org.sophie2.extra.func.embeddednothing - no tests
org.sophie2.extra.func.pdfnothig - OK
org.sophie2.extra.func.printnothing - no tests
org.sophie2.main.app.commons rename AppViewUnitTest to AppViewTest, make it an integration test. Thoroughly refactor BookViewUnitTest. Move AudioContentViewTest and VideoContentViewTest to org.sophie2.main.func.media, refactor ContentViewTest, review FrameAddUndoViewTest, fix "catch(Throwable e)" statements, remove any "fail('not implemented')" methods.
org.sophie2.main.app.halos
org.sophie2.main.app.layout
org.sophie2.main.app.menus
org.sophie2.main.app.model
org.sophie2.main.dialogs.input
org.sophie2.main.func.config
org.sophie2.main.func.file
org.sophie2.main.func.help
org.sophie2.main.func.image
org.sophie2.main.func.links
org.sophie2.main.func.media
org.sophie2.main.func.resources
org.sophie2.main.func.servers
org.sophie2.main.layout.mydoggy
org.sophie2.main.layout.vldocking
org.sophie2.main.media.fobs
org.sophie2.main.persistence.r1
org.sophie2.main.persistence.r2
org.sophie2.main.scene.jogl
org.sophie2.main.scene.simple
org.sophie2.main.skin.alternative
org.sophie2.main.ws_connector
org.sophie2.server
org.sophie2.server.connector
org.sophie2.server.persistence

Implementation

(Describe and link the implementation results here (from the wiki or the repository).)

Testing

(Place the testing results here.)

Comments

(Write comments for this or later revisions here.)