AUTHOR_APP_TUNING_R3

[Astea]

wiki page: AUTHOR_APP_TUNING_R3 - effort: 1d

[dido]

Analysis reviewed 4p (10m)

[meddle]

The design is good :)

• The repeating code in TilePainter.java is bad thing.
• And the fact that the xml is moved out of the distrib directory is minus too, but if at the moment is impossible otherwise, so be it...

3.5p (50m)

[peko]

• Fixed the tile painter.
• Fixed the tab tab. Its height is moved to the skin.

[meddle]

Problems:

• There are issues with default skin bound controls icons. The buttons in the book titlebar for next/prev page and for search.
• When changing between skins the flap position must be preserved.
• When choosing maximize the window is not maximized properly because of its shadow.
• When switching between skins the page desktop constantly expands.
• When resizing flap and then minimizing it we have the bug that is visible in the attachment in the wiki page. (Hard to reproduce, but ugly :))

2p (90m)

[dido]

there are 2 ways to proceed

• The first one is fix this issues in this task
• The second is to include them in the next revision

Also there are a lot of issues related to the documents tab bar, documents window, flaps, huds and so on.
My opinion is that fixing this specific issues in this revision gives them higher priority than they deserve.
However I agree that the following issues should be fixed before integrating this in the application.

• When changing between skins the flap position must be preserved.
• When switching between skins the page desktop constantly expands.
• When resizing flap and then minimizing it we have the bug that is visible in the attachment in the wiki page. (Hard to reproduce, but ugly :))

It seems to me that the 2 other issues are little more complex than explained.

• There are issues with default skin bound controls icons. The buttons in the book titlebar for next/prev page and for search. - Book view options panel is far far away from the desired state. Instead of fixing little part my proposal is to push this to final stage and finish with this once and for all. (It's not nice that the functionality in the old skin suffers from this)
• When choosing maximize the window is not maximized properly because of its shadow. - Again the look and feel for documents window is not finished. The margins are not correct, the shadow doesn't draw itself correctly (not so hard to reproduce) etc.

Should we fix the last two issues in this revision or leave them for the next one?
Please share your thoughts on this.

[peko]

• There are issues with default skin bound controls icons. The buttons in the book titlebar for next/prev page and for search. - fixed. Now buttons have different icons for every state.
• When changing between skins the flap position must be preserved. - this is not possible, since look and feel updating of mydoggy is not something we can control.
• When choosing maximize the window is not maximized properly because of its shadow. - decided to leave the shadow for the time being. Otherwise the book window will be left with an ugly border.
• When switching between skins the page desktop constantly expands. - fixed.
• When resizing flap and then minimizing it we have the bug that is visible in the attachment in the wiki page. (Hard to reproduce, but ugly :))... This is something that appeared only once on my machine and I cannot understand why, because it happens rarely and there is little success in finding the reason. This will be fixed in the next revision.

[peko]

Added new tabs for the layout. These are exactly the tabs that are provided by shift. There are still issues with making mydoggy look exactly as proposed by shift.

[meddle]

OK but the bug with the reader in full screen and the right border must be fixed and in the next revision the default skin must be the new one.

3.5p (40m)

[deyan]

Batch update from file query-obsoleted.csv