Ticket #1637 (closed planned_task: obsolete)

Opened 11 years ago

Last modified 10 years ago

GROUP_ANNOTATIONS_R0

Reported by: mitex Owned by: mitex
Priority: major Milestone: M05_PRE5
Component: DOMAIN_ELEMENTS Version: 2.0
Keywords: annotation, sticky, highlight, audio annotation, book extra Cc:
Category: EXTRA Effort: 5
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: mitex Design_owners: milo, mitex
Imp._owners: mitex Test_owners:
Analysis_reviewers: pap Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 0

Description (last modified by pap) (diff)

Change History

comment:1 Changed 11 years ago by mitex

  • Owner set to mitex
  • Status changed from new to s1a_analysis_started

comment:2 Changed 11 years ago by pap

  • Description modified (diff)

comment:3 Changed 11 years ago by mitex

  • Design_owners changed from mitex to milo, mitex

comment:4 Changed 11 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:5 Changed 10 years ago by pap

  • Cc mitex added
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to pap
  • Analysis_score changed from 0 to 3

What is written is right but there are some things to note.

  • First the Implementation idea is something that proves that the analysis is implementable at all. You cannot write to see the design, because this means to look into the future. You should fix this!
  • Non functioning buttons like the Open extras you mention are bad and confusing. I'd rather drop this.
  • If you plan to do audio annotations you should make sure they are usable.

comment:6 Changed 10 years ago by mitex

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:7 Changed 10 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

comment:8 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle

I'm passing it only because it is already implemented in the trunk and I don't want to make you write stuff about this task, when you are implementing new stuff. But please fix that:

  • You need more detailed tests, view tests, and model tests, you are testing only one method of all the logic
  • Please provide UML diagram.
  • You must describe how the audio annotation will be visible to the user... You said in the analysis that you will display it.

3p (40m)

comment:9 Changed 10 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:10 Changed 10 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:11 Changed 10 years ago by deyan

  • Cc mitex removed

Batch update from file import.csv

comment:12 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle

I'll pass it, the implementation is according the design provided, but some of the changesets you provided are unnecessary, they are from other tasks:

  • [1980] : This changeset contains code from jani's GROUP_TEMPLATES_R0 task.
  • [1879] : Contains code for BaseProList optimization.
  • [1896] : A bugfix related to the ScenePageWorkArea.
  • [1948] : UNTRACKED_BUG_FIX in ListPalette, selected item.

I removed this changests from your list. Other thing, It's hard for me to read some parts of your code, I think that you must read our analysis, design and implementation reviews carefully and fix the appropriate documentations.
3p (40m)

comment:13 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.