Ticket #1781 (closed unplanned_task: obsolete)
GROUP_BASE_HALOS_AND_FRAME_POSITION_R1
Reported by: | peko | Owned by: | peko |
---|---|---|---|
Priority: | major | Milestone: | M10_BETA2 |
Component: | uncategorized | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | unknown | Effort: | |
Importance: | Ticket_group: | ||
Estimated Number of Hours: | Add Hours to Ticket: | ||
Billable?: | Total Hours: | ||
Analysis_owners: | Design_owners: | peko, vlado | |
Imp._owners: | peko, vlado | Test_owners: | |
Analysis_reviewers: | Changelog: | ||
Design_reviewers: | kyli | Imp._reviewers: | pap |
Test_reviewers: | Analysis_score: | 0 | |
Design_score: | 3 | Imp._score: | 3 |
Test_score: | 0 |
Description
This group unites BASE_HALOS_R1 and FRAME_POSITION_R1. This got quite complicated and these two have a lot in common.
GROUP_BASE_HALOS_AND_FRAME_POSITION_R1
Ticket | Summary | Status | Effort |
---|---|---|---|
#248 | BASE_HALOS_R1 | closed | 3 |
#750 | FRAME_POSITION_R1 | closed | 1 |
Change History
comment:2 Changed 16 years ago by peko
- Owner set to peko
- Status changed from s1c_analysis_ok to s2a_design_started
comment:3 Changed 16 years ago by peko
- Status changed from s2a_design_started to s2b_design_finished
comment:4 Changed 16 years ago by kyli
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to kyli
- One of the analyses is already failed once because it should not include only halos but also huds, the other should include some model/performance improvements in my opinion. However, there are really not such task requirements so the design is according to the analysis.
- The design text is bloated in 3 different pages, so it is hard to read it all. I think this is not the idea of writing all the designs in this wiki.
- The implementation commits should be separated from the unit test commits, I guess.
- Commits without a message are not allowed.
- Commits of new code together with trunk sync are not allowed. The implementation will not pass if you don't synchronize with trunk again first.
comment:5 Changed 16 years ago by peko
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to peko, vlado
comment:6 Changed 16 years ago by vlado
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:7 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3
- Imp._reviewers set to pap
- I pass it but there were several issues.
- The code was very hard to synchornise with trunk
- The unit tests are failing for me - pelase try to fix that
- I really think you should've used some more skinning - alignments for example
- Otherwise I really like most of the visual result of the task
- Good luck
Note: See
TracTickets for help on using
tickets.